Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add a TranscriptionSegment callback? #159

Open
Josscii opened this issue Jun 5, 2024 · 4 comments
Open

Is it possible to add a TranscriptionSegment callback? #159

Josscii opened this issue Jun 5, 2024 · 4 comments
Labels
enhancement Improves existing code

Comments

@Josscii
Copy link

Josscii commented Jun 5, 2024

during file transcribe, it is more convenient if we can get callback of a TranscriptionSegment, the TranscriptionProgress is not that helpful.

@ldenoue
Copy link

ldenoue commented Jun 5, 2024

It would be very useful to get TranscriptionSegment indeed, with the word timestamps when available. Currently the TranscriptionProgress text contains raw strings such as <|startoftranscript|><|pl|><|transcribe|><|0.00|> Jeżeli zastanawiajcie się which isn't easy to parse.

@ZachNagengast
Copy link
Contributor

We're currently not building the segments before a window completes, but it may be possible to have it return when we see two timestamp tokens surrounding text come through. Would you prefer a separate callback for this, or a configurable parameter on the existing callback eg. callbackInterval: .token or callbackInterval: .segment?

@ZachNagengast ZachNagengast added the enhancement Improves existing code label Jun 5, 2024
@Josscii
Copy link
Author

Josscii commented Jun 6, 2024

What's the relationship of the TranscriptionProgress callback and the TranscriptionSegment callback?

Will they callback at the same time? If so, may be merged into one. If not, may be separated.

@ldenoue
Copy link

ldenoue commented Jun 6, 2024

I would prefer a separate callback that returns TranscriptionSegment structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing code
Projects
Status: TODO
Development

No branches or pull requests

3 participants