Fixes #26996 - pulp 3 docker CRUD

Author: ianballou

app/services/katello/pulp3/repository/docker.rb

@@ -0,0 +1,55 @@
+require 'pulp_docker_client'
+
+module Katello
+  module Pulp3
+    class Repository
+      class Docker < ::Katello::Pulp3::Repository
+        def api_client
+          PulpDockerClient::ApiClient.new(smart_proxy.pulp3_configuration(PulpDockerClient::Configuration))
+        end
+
+        def api_exception_class
+          PulpDockerClient::ApiError
+        end
+
+        def remote_class
+          PulpDockerClient::DockerRemote
+        end
+
+        def remotes_api
+          PulpDockerClient::RemotesDockerApi.new(api_client)
+        end
+
+        def distribution_class
+          PulpDockerClient::DockerDistribution
+        end
+
+        def distributions_api
+          PulpDockerClient::DistributionsDockerApi.new(api_client)
+        end
+
+        def remote_options
+          if root.url.blank?
+            super
+          else
+            options = {url: root.url, upstream_name: root.docker_upstream_name}
+            if root.docker_tags_whitelist && root.docker_tags_whitelist.any?
+              options[:whitelist_tags] = root.docker_tags_whitelist.join(",")
+            else
+              options[:whitelist_tags] = nil
+            end
+            common_remote_options.merge(options)
+          end
+        end
+
+        def distribution_options(path)
+          {
+            base_path: path,
+            repository_version: repo.version_href,
+            name: "#{backend_object_name}"
+          }
+        end
+      end
+    end
+  end
+end

katello.gemspec

@@ -45,6 +45,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency "pulpcore_client"
   gem.add_dependency "pulp_file_client", "< 3.0.0"
   gem.add_dependency "pulp_ansible_client"
+  gem.add_dependency "pulp_docker_client"
 
   # UI
   gem.add_dependency "deface", '>= 1.0.2', '< 2.0.0'

lib/katello/repository_types/docker.rb

@@ -1,5 +1,8 @@
 Katello::RepositoryTypeManager.register(::Katello::Repository::DOCKER_TYPE) do
   service_class Katello::Pulp::Repository::Docker
+  pulp3_service_class Katello::Pulp3::Repository::Docker
+  pulp3_skip_publication true
+  pulp3_plugin 'pulp_docker'
 
   content_type Katello::DockerManifest, :priority => 1, :pulp2_service_class => ::Katello::Pulp::DockerManifest, :user_removable => true
   content_type Katello::DockerManifestList, :priority => 2, :pulp2_service_class => ::Katello::Pulp::DockerManifestList

test/actions/pulp3/orchestration/docker_create_test.rb

@@ -0,0 +1,26 @@
+require 'katello_test_helper'
+
+module ::Actions::Pulp3
+  class DockerCreateTest < ActiveSupport::TestCase
+    include Katello::Pulp3Support
+
+    def setup
+      @master = FactoryBot.create(:smart_proxy, :default_smart_proxy, :with_pulp3)
+      @repo = katello_repositories(:busybox)
+      ensure_creatable(@repo, @master)
+    end
+
+    def test_create
+      ForemanTasks.sync_task(::Actions::Pulp3::Orchestration::Repository::Create, @repo, @master)
+      @repo.reload
+
+      assert @repo.remote_href
+      refute @repo.version_href
+
+      repo_reference = Katello::Pulp3::RepositoryReference.find_by(:root_repository_id => @repo.root.id,
+                                                                   :content_view_id => @repo.content_view.id)
+      assert repo_reference
+      assert repo_reference.repository_href
+    end
+  end
+end

test/actions/pulp3/orchestration/docker_delete_test.rb

@@ -0,0 +1,42 @@
+require 'katello_test_helper'
+
+module ::Actions::Pulp3
+  class DockerDeleteTest < ActiveSupport::TestCase
+    include ::Katello::Pulp3Support
+
+    def setup
+      @master = FactoryBot.create(:smart_proxy, :default_smart_proxy, :with_pulp3)
+      @repo = katello_repositories(:busybox)
+      create_repo(@repo, @master)
+      ForemanTasks.sync_task(
+        ::Actions::Katello::Repository::MetadataGenerate, @repo,
+        repository_creation: true)
+
+      assert Katello::Pulp3::RepositoryReference.find_by(
+        :root_repository_id => @repo.root.id,
+        :content_view_id => @repo.content_view.id)
+
+      refute_empty Katello::Pulp3::DistributionReference.where(
+        root_repository_id: @repo.root.id)
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Delete, @repo, @master)
+      @repo.reload
+    end
+
+    def test_repository_reference_is_deleted
+      repo_reference = Katello::Pulp3::RepositoryReference.find_by(
+        :root_repository_id => @repo.root.id,
+        :content_view_id => @repo.content_view.id)
+
+      assert_nil repo_reference
+    end
+
+    def test_distribution_references_are_deleted
+      distribution_references = Katello::Pulp3::DistributionReference.where(
+        root_repository_id: @repo.root.id)
+
+      assert_empty distribution_references
+    end
+  end
+end

test/actions/pulp3/orchestration/docker_update_test.rb

@@ -0,0 +1,119 @@
+require 'katello_test_helper'
+
+module ::Actions::Pulp3
+  class DockerUpdateTest < ActiveSupport::TestCase
+    include Katello::Pulp3Support
+
+    def setup
+      @master = FactoryBot.create(:smart_proxy, :default_smart_proxy, :with_pulp3)
+      @repo = katello_repositories(:busybox)
+      create_repo(@repo, @master)
+
+      ForemanTasks.sync_task(
+        ::Actions::Katello::Repository::MetadataGenerate, @repo,
+        repository_creation: true)
+
+      assert_equal 1,
+        Katello::Pulp3::DistributionReference.where(root_repository_id: @repo.root.id).count,
+        "Expected a distribution reference."
+      @repo.root.update_attributes(
+        verify_ssl_on_sync: false,
+        ssl_ca_cert: katello_gpg_keys(:unassigned_gpg_key),
+        ssl_client_cert: katello_gpg_keys(:unassigned_gpg_key),
+        ssl_client_key: katello_gpg_keys(:unassigned_gpg_key))
+    end
+
+    def test_update_ssl_validation
+      refute @repo.root.verify_ssl_on_sync, "Respository verify_ssl_on_sync option was false."
+      @repo.root.update_attributes(
+        verify_ssl_on_sync: true)
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Update,
+        @repo,
+        @master)
+    end
+
+    def test_update_url
+      @repo.root.update_attributes(
+        url: 'http://website.com/')
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Update,
+        @repo,
+        @master)
+    end
+
+    def test_update_upstream_name
+      @repo.root.update_attributes(
+        docker_upstream_name: 'test')
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Update,
+        @repo,
+        @master)
+    end
+
+    def test_update_whitelist_tags
+      @repo.root.update_attributes(
+        docker_tags_whitelist: 'test_tag')
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Update,
+        @repo,
+        @master)
+    end
+
+    def test_update_whitelist_tags_empty
+      @repo.root.update_attributes(
+        docker_tags_whitelist: nil)
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Update,
+        @repo,
+        @master)
+    end
+
+    def test_update_unset_unprotected
+      assert @repo.root.unprotected
+      assert_equal 1, Katello::Pulp3::DistributionReference.where(
+        root_repository_id: @repo.root.id).count
+
+      @repo.root.update_attributes(unprotected: false)
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Update,
+        @repo,
+        @master)
+
+      dist_refs = Katello::Pulp3::DistributionReference.where(
+         root_repository_id: @repo.root.id)
+
+      assert_equal 1, dist_refs.count, "Expected 1 distribution reference."
+    end
+
+    def test_update_set_unprotected
+      @repo.root.update_attributes(unprotected: false)
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Update,
+        @repo,
+        @master)
+
+      dist_refs = Katello::Pulp3::DistributionReference.where(
+        root_repository_id: @repo.root.id)
+
+      assert_equal 1, dist_refs.count, "Expected only 1 distribution reference."
+      @repo.root.update_attributes(unprotected: true)
+
+      ForemanTasks.sync_task(
+        ::Actions::Pulp3::Orchestration::Repository::Update,
+        @repo,
+        @master)
+
+      dist_refs = Katello::Pulp3::DistributionReference.where(
+        root_repository_id: @repo.root.id)
+      assert_equal 1, dist_refs.count, "Expected a distribution reference."
+    end
+  end
+end