You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not a fan of the UseTrait pattern it's against a few best practices and resource intensive (we have to calculate recursively all the traits used by all the classes before knowing) I think an interface or method_exists based approach would be better
I also think if we do this right we can make the Repository class optionnal in favor of a basic one that infers all that is needed, we would only need the Controller like this (I don't like to have to keep 3 different files in wildly different places in sync like this it's really a lot of back and forth)
Can we maybe create a milestone pinned issue to reference what we should make happen in v4 and discuss this ?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Dropping some ideas for v4
For instance we could automatically make fields translatable or not if the name is found in the translatable fields
I'm not a fan of the
UseTrait
pattern it's against a few best practices and resource intensive (we have to calculate recursively all the traits used by all the classes before knowing) I think an interface ormethod_exists
based approach would be betterI also think if we do this right we can make the Repository class optionnal in favor of a basic one that infers all that is needed, we would only need the Controller like this (I don't like to have to keep 3 different files in wildly different places in sync like this it's really a lot of back and forth)
Can we maybe create a milestone pinned issue to reference what we should make happen in v4 and discuss this ?
Beta Was this translation helpful? Give feedback.
All reactions