Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddRefmapName does not check if the refmap actually exists #37

Open
Jamalam360 opened this issue Oct 30, 2023 · 0 comments
Open

AddRefmapName does not check if the refmap actually exists #37

Jamalam360 opened this issue Oct 30, 2023 · 0 comments

Comments

@Jamalam360
Copy link

  1. make an empty mixin config
  2. mixin will not generate a refmap
  3. plugin will still add the refmap field to the mixin config

This doesn't cause a crash but causes warnings to be logged at runtime
Jamalam360 added a commit to Jamalam360/architectury-plugin that referenced this issue Oct 31, 2023
@Jamalam360
Check refmaps exist before adding them to mixin configs (architectury#37
d33fcb0 
)

Idea formatted automatically, that's why the diff looks weird
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jamalam360