Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fabric-Loom-Remap to the Common manifest #34

Open
MichaelHillcox opened this issue Aug 23, 2023 · 4 comments
Open

Add Fabric-Loom-Remap to the Common manifest #34

MichaelHillcox opened this issue Aug 23, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@MichaelHillcox
Copy link

When attempting to use an Arch project inside a Non-Arch-Loom, specifically where the common project uses loom instead of Arch loom or VanillaGradle libs that do not have Fabric-Loom-Remap defined in the jar manifest will cause loom to not properly remap the dependency.

I'll be honest, this is information from @modmuss50 and I don't fully understand the problem but adding this to the manifest fixes the issue. This is less a bug in Arch loom and more of a feature request for better cross build tools compatability.

Example of what needs to be added to the manifest.

jar {
    manifest {
        attributes 'Fabric-Loom-Remap': true
    }
}
@shedaniel shedaniel added the enhancement New feature or request label Aug 23, 2023
@Juuxel
Copy link
Member

Juuxel commented Aug 23, 2023

I think this belongs in Arch Plugin, Loom doesn't have any concept of "common" projects.

@Juuxel Juuxel transferred this issue from architectury/architectury-loom Aug 23, 2023
@shedaniel
Copy link
Member

I can make Architectury Plugin add the attribute or just tell everyone to add the attribute themselves (plus do it in architectury api and etc)

@MichaelHillcox
Copy link
Author

Ideally an on by default option would be best as, from my knowledge, it won't affect any other toolchain but does provide good support for using normal loom to back a multi-project workspace.

If it was added to the templates, it would likely be enough, no sure really.

@Juuxel
Copy link
Member

Juuxel commented Aug 23, 2023

IMO it fits the plugin better than the templates - the template buildscripts are already pretty long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants