Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3 NeoForge] ArchLoom trying to remap accessor away from Mojmap #244

Open
TelepathicGrunt opened this issue Oct 26, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@TelepathicGrunt
Copy link

The problematic Accessor Mixin and branch it is in:
https://github.com/TelepathicGrunt/StructureVoidToggle/blob/Arch-1.21.3/common/src/main/java/com/telepathicgrunt/structurevoidtoggle/mixin/StructureVoidBlockAccessor.java

I am using arch loom 1.7-SNAPSHOT and arch plugin 3.4-SNAPSHOT and currently finding when I run Neoforge, it crashes de to this accessor mixin's SHAPE target to field_11589 which fails. Neoforge uses Mojmap so there should not be remapping done here. It should all stay in Mojmap.

Caused by: org.spongepowered.asm.mixin.gen.throwables.InvalidAccessorException: No candidates were found matching field_11589:Lnet/minecraft/world/phys/shapes/VoxelShape; in net/minecraft/world/level/block/StructureVoidBlock for structure_void_toggle.mixins.json:StructureVoidBlockAccessor from mod structure_void_toggle->@Accessor[FIELD_SETTER]::setSHAPE(Lnet/minecraft/world/phys/shapes/VoxelShape;)V [ACCESSOR Applicator Phase -> structure_void_toggle.mixins.json:StructureVoidBlockAccessor from mod structure_void_toggle -> Apply Accessors -> -> Locate -> structure_void_toggle.mixins.json:StructureVoidBlockAccessor from mod structure_void_toggle->@Accessor[FIELD_SETTER]::setSHAPE(Lnet/minecraft/world/phys/shapes/VoxelShape;)V]

Full error:
https://pastebin.com/raw/aij6XV1Q

@Juuxel Juuxel added this to the 1.9 milestone Dec 6, 2024
@Juuxel Juuxel added the bug Something isn't working label Dec 6, 2024
@Juuxel
Copy link
Member

Juuxel commented Dec 7, 2024

I can't reproduce this with 1.9 in isolation without Arch Plugin. Arch Plugin isn't currently compatible with Loom 1.9, so I'll try it again once that's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants