Datagen task doesn’t exit when finished

[JT122406]

When running forge or fabric Datagen the task doesn't end it just continues forever until force stopped by input.

[qyl27]

Same issue, and it has already existed for many months.

[Fuzss]

Maybe related: neoforged/FancyModLoader#117

[qyl27]

Maybe related: neoforged/FancyModLoader#117

But this issue also happens on LexForge and Fabric.
I have noticed it since 1.18.
Maybe a deeper problem here.

[Fuzss]

I meant to refer to the solution the PR is implementing. Maybe it's applicable here as well.

[qyl27]

I meant to refer to the solution the PR is implementing. Maybe it's applicable here as well.

Oh, so they should do same in ForgeModLoader and Fabric Loader.

[forkiesassds]

Looking at it closer. Fabric API has 2 mixins, one for client and another for server. The client mixin uses System.exit(0), whilst the server mixin simply cancels main() after running datagen. Since main() has finished running but as there are several ExecutorService pool threads that remain running, this causes the task to never stop. Or well something at least to do with the Architectury Transformer...

[Jab125]

Does adding this to the dependency list fix any issues?

// Requires Jitpack
dependencies {
    if (System.getenv("CI") != null) {
        // For 1.21
        modLocalRuntime "com.github.jab125.architectury-data-generation-fix:architectury-data-generation-fix-fabric:21.0.1"
    }
}

[Fuzss]

Not using data gen on Fabric, but this mixin fixes the issue for NeoForge.

https://github.com/Fuzss/puzzleslib/blob/main/1.21/NeoForge/src/main/java/fuzs/puzzleslib/neoforge/mixin/DatagenModLoaderNeoForgeMixin.java

[JT122406]

Mixins and extra dependencies shouldn’t be needed for this to work it should just work with arch loom at least with the fabric datagen, the forge I can understand because loom is based on fabric