-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The calculated colors don't return exactly what Sass returns. #5
Comments
Thanks for the heads up @Aptary - I suspect this is mostly due differences in how JS and Ruby treat numbers / math. Will update our tests and see if we can't get it sorted out. |
I'm having the same problem. It seemed like just the tool I was looking for, until I started using it and I kept getting values that were not the same between this tool and sass. :( SassMe: lighten(#7EB9E8, 26) --> #f2f8fd |
Yep, same problem here. :( |
Pull requests welcome. |
The project now lives under my github jimniels/sassme (and is live at jim-nielsen.com/sassme. Any suggestions, issues, improvements, or PRs are welcome there :) FWIW: this problem was fixed in v2 of the site I launched. The slight color differences were due to a tiny rounding error in javascript. |
What even are JavaScript numbers? |
Javascript numbers are strings. |
Hi,
Love this tool, but just wanted to point out that there is a little problem in calculating the colours. I'll give you a couple of examples.
Using the tool, lightening or darkening a color by 0 changes the color, when it should actually remain the same.
Eg: #123456.
Lighten by 0 gives #133659
Darken by 0 gives #123354
And sticking with #123456, darkening it by 10% with SASS gives #091a2c, but your tool returns #09192a.
Cheers
The text was updated successfully, but these errors were encountered: