Skip to content

Commit ba6cd8a

Browse files
author
rsc
committed
drop NADDRS and INDIRECT; too many names
1 parent 030a477 commit ba6cd8a

File tree

4 files changed

+13
-15
lines changed

4 files changed

+13
-15
lines changed

fs.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -335,10 +335,10 @@ bmap(struct inode *ip, uint bn, int alloc)
335335

336336
if(bn < NINDIRECT){
337337
// Load indirect block, allocating if necessary.
338-
if((addr = ip->addrs[INDIRECT]) == 0){
338+
if((addr = ip->addrs[NDIRECT]) == 0){
339339
if(!alloc)
340340
return -1;
341-
ip->addrs[INDIRECT] = addr = balloc(ip->dev);
341+
ip->addrs[NDIRECT] = addr = balloc(ip->dev);
342342
}
343343
bp = bread(ip->dev, addr);
344344
a = (uint*)bp->data;
@@ -375,16 +375,16 @@ itrunc(struct inode *ip)
375375
}
376376
}
377377

378-
if(ip->addrs[INDIRECT]){
379-
bp = bread(ip->dev, ip->addrs[INDIRECT]);
378+
if(ip->addrs[NDIRECT]){
379+
bp = bread(ip->dev, ip->addrs[NDIRECT]);
380380
a = (uint*)bp->data;
381381
for(j = 0; j < NINDIRECT; j++){
382382
if(a[j])
383383
bfree(ip->dev, a[j]);
384384
}
385385
brelse(bp);
386-
bfree(ip->dev, ip->addrs[INDIRECT]);
387-
ip->addrs[INDIRECT] = 0;
386+
bfree(ip->dev, ip->addrs[NDIRECT]);
387+
ip->addrs[NDIRECT] = 0;
388388
}
389389

390390
ip->size = 0;

fs.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@ struct superblock {
1515
uint ninodes; // Number of inodes.
1616
};
1717

18-
#define NADDRS (NDIRECT+1)
1918
#define NDIRECT 12
20-
#define INDIRECT 12
2119
#define NINDIRECT (BSIZE / sizeof(uint))
22-
#define MAXFILE (NDIRECT + NINDIRECT)
20+
#define MAXFILE (NDIRECT + NINDIRECT)
2321

2422
// On-disk inode structure
2523
struct dinode {
@@ -28,7 +26,7 @@ struct dinode {
2826
short minor; // Minor device number (T_DEV only)
2927
short nlink; // Number of links to inode in file system
3028
uint size; // Size of file (bytes)
31-
uint addrs[NADDRS]; // Data block addresses
29+
uint addrs[NDIRECT+1]; // Data block addresses
3230
};
3331

3432
// Inodes per block.

fsvar.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ struct inode {
1111
short minor;
1212
short nlink;
1313
uint size;
14-
uint addrs[NADDRS];
14+
uint addrs[NDIRECT+1];
1515
};
1616

1717
#define I_BUSY 0x1

mkfs.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,17 +259,17 @@ iappend(uint inum, void *xp, int n)
259259
}
260260
x = xint(din.addrs[fbn]);
261261
} else {
262-
if(xint(din.addrs[INDIRECT]) == 0) {
262+
if(xint(din.addrs[NDIRECT]) == 0) {
263263
// printf("allocate indirect block\n");
264-
din.addrs[INDIRECT] = xint(freeblock++);
264+
din.addrs[NDIRECT] = xint(freeblock++);
265265
usedblocks++;
266266
}
267267
// printf("read indirect block\n");
268-
rsect(xint(din.addrs[INDIRECT]), (char*) indirect);
268+
rsect(xint(din.addrs[NDIRECT]), (char*) indirect);
269269
if(indirect[fbn - NDIRECT] == 0) {
270270
indirect[fbn - NDIRECT] = xint(freeblock++);
271271
usedblocks++;
272-
wsect(xint(din.addrs[INDIRECT]), (char*) indirect);
272+
wsect(xint(din.addrs[NDIRECT]), (char*) indirect);
273273
}
274274
x = xint(indirect[fbn-NDIRECT]);
275275
}

0 commit comments

Comments
 (0)