Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APP-3309): Update ProposalActions component to support edit-mode #354

Merged
merged 36 commits into from
Dec 6, 2024
Merged

feat(APP-3309): Update ProposalActions component to support edit-mode #354

merged 36 commits into from
Dec 6, 2024

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Nov 28, 2024 •
edited
Loading

Description

  • Improve rendering of decoded parameters to correctly render tuple and array types
  • Support editMode to add custom-actions to proposals

Task: APP-3309

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth force-pushed the APP-3309-improve-decoded-view branch 2 times, most recently from 323fdbe to bff61b3 Compare November 29, 2024 12:24
@cgero-eth
Start implementation of edit-mode
7e93f1e
@cgero-eth
Update yarn.lock
3d4e000
@cgero-eth
Code cleanup, add support for add and remove array items
f205735
@cgero-eth
Code cleanup
9cb6be8
@cgero-eth
Code cleanup
27d22a8
@cgero-eth
Code cleanup, support undefined | null values
1330641
@cgero-eth
Update CHANGELOG.md
d15992d
@cgero-eth
Update proposalActionsItem.api.ts
af9dae0
@cgero-eth
Update proposalActionsItem.tsx
4c085c4
@cgero-eth
Update proposalActionsItemDecodedView.test.tsx
b98edd8
@cgero-eth
Forward formPrefix to decoded-view component
abeb17d
@cgero-eth
Fix value setter
98ccfbd
@cgero-eth
Rewrite code to implement new ProposalActionsDecoder component
a04389c
@cgero-eth
Fix processing of bool types, cleanup strings
46ebf50
@cgero-eth
Correctly store bool values and encode tx data
310a059
@cgero-eth
Small fixes
9b3bb5b
@cgero-eth
Fix nested-params for tuple, display copy-data button on read/watch m…
36605cc 
…odes
@cgero-eth
Fix exports
0065359
@cgero-eth
Implement tests for useFormContext hook
69a1805
@cgero-eth
Update ProposalActionsItem tests
6ed578d
@cgero-eth
Change payable property to stateMutability
2b1a370
@cgero-eth
Start writing tests for decoder utils, update value validation
e738298
@cgero-eth cgero-eth force-pushed the APP-3309-improve-decoded-view branch from 52be43c to e738298 Compare December 3, 2024 10:36
@cgero-eth cgero-eth changed the title WIP feat(APP-3309): Update ProposalActions component to support edit-mode feat(APP-3309): Update ProposalActions component to support edit-mode Dec 4, 2024
@cgero-eth cgero-eth marked this pull request as ready for review December 4, 2024 10:47
@cgero-eth cgero-eth requested a review from a team December 4, 2024 10:58
shan8851
shan8851 previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@shan8851 shan8851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@cgero-eth cgero-eth merged commit 38c2d19 into main Dec 6, 2024
4 checks passed
@cgero-eth cgero-eth deleted the APP-3309-improve-decoded-view branch December 6, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shan8851 shan8851 shan8851 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @shan8851