Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/utils/download.go:GetLinks does not process absolute references correctly #112

Closed
sc07kvm opened this issue Apr 16, 2024 · 2 comments
Closed

pkg/utils/download.go:GetLinks does not process absolute references correctly #112

sc07kvm opened this issue Apr 16, 2024 · 2 comments

Comments

@sc07kvm
Copy link

sc07kvm commented Apr 16, 2024

url.JoinPath function is used in GetLinks. It will be more correct to use URL.ResolveReference or URL.Parse
@geyslan
Copy link
Member

geyslan commented Apr 16, 2024

Hi @sc07kvm. Would you mind raising a PR with your suggestion, so we can analyse it. Thanks!

@geyslan
Copy link
Member

geyslan commented Jan 9, 2025 •
edited
Loading

url.JoinPath already calls Parse, so it's safe to rely on it.

@geyslan geyslan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sc07kvm @geyslan