-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve combobox styles #36224
Comments
2 tasks
2 tasks
Shivam-z
pushed a commit
to Shivam-z/appsmith
that referenced
this issue
Sep 26, 2024
## Description Added styles for input to the combobox Separate reused components(FieldDescription, FieldError, FieldLabel, FieldListPopover) Fixes appsmithorg#36224 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10888601720> > Commit: 7ef81de > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10888601720&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Mon, 16 Sep 2024 17:33:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Added a more comprehensive set of button size examples to the `Button.stories.tsx` file. - Introduced a new `FieldDescription` component in the `ComboBox.tsx` file to handle field descriptions. - **Styling Improvements** - Refined the spacing, padding, and text size for the `Button` component based on its size. - Enhanced the visual feedback for checkboxes in invalid and selected states in the `Checkbox` component. - Simplified the CSS structure and improved the visual states of the `ComboBox` component. - **Refactor** - Replaced legacy components in the `ComboBox` with more standardized design system components for improved consistency. - Removed the `ListBoxItem` component, indicating a change in the list box rendering approach. - Narrowed the allowed sizes for the `ComboBox` component, excluding "xSmall" and "large" sizes. - **Chores** - Removed the `ErrorMessage` component and its associated export in the `index.ts` file. - Added a `verbatimModuleSyntax` property to the `tsconfig.json` file, potentially affecting module handling. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: