Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]-[4000]:On clicking the 'x' icon in search fields, retain the cursor position inside the search field #18536

Open
1 task done
shadabbuchh opened this issue Nov 29, 2022 · 4 comments
Open
1 task done

[Bug]-[4000]:On clicking the 'x' icon in search fields, retain the cursor position inside the search field #18536

shadabbuchh opened this issue Nov 29, 2022 · 4 comments
Assignees
@dilippitchika
Labels
Ballpark: S ~2xDev in 1xSprint Bug Something isn't working Inviting Contribution Issues that we would like contributions to Medium Issues that frustrate users due to poor UX MultiSelect Widget Issues related to MultiSelect Widget MultiTree Select Widget Issues related to MultiTree Select Widget Production Select Widget Select or dropdown widget Table Widget V2 Issues related to Table Widget V2 TreeSelect Issues related to TreeSelect Widget UX Improvement Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@shadabbuchh
Copy link

shadabbuchh commented Nov 29, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Summary

On clicking the x icon in any search field (in table/select/multiselect etc. widgets) we should just erase the text and still maintain focus in the field so that the user does not have to click inside the search field again to type something. (just as the search field for widgets in entity explorer is behaving).
https://sqvpyjxewa.vmaker.com/record/pxV5w7nRo8jRGkE2

Why should this be worked on?

As of now if in any search field (in table/select/multiselect etc. widgets) when we click on the x icon to erase all the entered text, the cursor inside the search field is not retained and the focus moves out of it. So the user has to click inside the search field again to type something.
@shadabbuchh shadabbuchh added Enhancement New feature or request UX Improvement labels Nov 29, 2022
@shadabbuchh shadabbuchh added Select Widget Select or dropdown widget MultiSelect Widget Issues related to MultiSelect Widget MultiTree Select Widget Issues related to MultiTree Select Widget TreeSelect Issues related to TreeSelect Widget Table Widget V2 Issues related to Table Widget V2 labels Nov 29, 2022
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Nov 29, 2022
@dilippitchika dilippitchika added the Medium Issues that frustrate users due to poor UX label Dec 8, 2022
@dilippitchika dilippitchika changed the title [Feature]: On clicking the 'x' icon in search fields, retain the cursor position inside the search field [Bug]: On clicking the 'x' icon in search fields, retain the cursor position inside the search field Dec 8, 2022
@dilippitchika dilippitchika added Bug Something isn't working and removed Enhancement New feature or request labels Dec 8, 2022
@keyurparalkar
Copy link
Contributor

Stats

Stat Values
Reach 2000
Effort (months) 0.5

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: On clicking the 'x' icon in search fields, retain the cursor position inside the search field [Bug]-[2000]:On clicking the 'x' icon in search fields, retain the cursor position inside the search field Mar 31, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: On clicking the 'x' icon in search fields, retain the cursor position inside the search field [Bug]-[2000]:On clicking the 'x' icon in search fields, retain the cursor position inside the search field Mar 31, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]-[2000]:On clicking the 'x' icon in search fields, retain the cursor position inside the search field [Bug]-[4000]:On clicking the 'x' icon in search fields, retain the cursor position inside the search field Feb 29, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Widgets & Accelerators Pod Issues related to widgets & Accelerators and removed Widgets & Blocks Pod labels Jul 31, 2024
@carinanfonseca carinanfonseca added the Inviting Contribution Issues that we would like contributions to label Aug 21, 2024
@saiprabhu-dandanayak
Copy link
Contributor

@appsmithorg/query-js-pod , i would like to work on this issue.

@carinanfonseca
Copy link
Contributor

Go ahead @saiprabhu-dandanayak :)

@saiprabhu-dandanayak
Copy link
Contributor

saiprabhu-dandanayak commented Sep 12, 2024 •
edited
Loading

Hi @carinanfonseca , i have resolved this issue in 4 widgets i.e Table , SingleTreeSelect , MultiTreeSelect , MultiSelect , but unable to resolve in Select widget , select is being imported from blueprint-js/select library , here filter is implemented internally.

Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dilippitchika dilippitchika

Labels
Ballpark: S ~2xDev in 1xSprint Bug Something isn't working Inviting Contribution Issues that we would like contributions to Medium Issues that frustrate users due to poor UX MultiSelect Widget Issues related to MultiSelect Widget MultiTree Select Widget Issues related to MultiTree Select Widget Production Select Widget Select or dropdown widget Table Widget V2 Issues related to Table Widget V2 TreeSelect Issues related to TreeSelect Widget UX Improvement Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix:retained input reference on x icon click saiprabhu-dandanayak/appsmith
7 participants
@Nikhil-Nandagopal @rahulbarwal @keyurparalkar @dilippitchika @shadabbuchh @carinanfonseca @saiprabhu-dandanayak