[DOC] Installation instruction incomplete

[b1llab0ng]

Describe the bug
Installation instructions in README.md file and on the Download and installation web page are outdated. Missing coverage for autogen.sh script.

To Reproduce
Steps to reproduce the behavior:

1. GIT Clone fresh Master source in a new empty folder
2. Attempt to execute ./configure per installation instructions fails, file not found (without prior executing autogen.sh script, as not mentioned in instructions, the configure file does not exist yet).

Expected behavior
Installation instructions expected to be complete from fresh GIT cloned copy.
Installation instructions to be updated to add prior to execute ./configure, the step to execute the autogen.sh script in order to get the necessary configure script file.

Screenshots
See * mark below:

System (please complete the following information):

• OS: Debian
• OS version: 4.9.189-3 (2019-09-02) x86_64 GNU/Linux
• Tcpreplay Version 4.3.2 (build git:v4.3.2-2-ga00fd476)

Additional context
N/A

[fklassen]

You are missing the Donwloads step in the doc. Release tarballs have ./configure script.

The configure script is not included in the source code, as is common practise. Proper generation of the script requires autogen which is very version dependent. Developers create releases with sudo make test && make dist. Regular users use releases.

[b1llab0ng]

Ok. I further read the instructions and figured it out. It's true that the tar ball contains the configure file.
I intermingled the download instructions for developer cloning from GIT and followed simple installation instructions for std user, leading to why I opened this ticket at first.
Although, perhaps it would be a good addition for complementing instructions, to provide the installation instructions for when cloning from GIT; then prior running the autogen.sh script is necessary for obtaining the ./configure.

[fklassen]

Point taken. Will target next fix release.

[b1llab0ng]

Thank you

[resolutedreamer]

Hello. I think this is still a problem. I downloaded the source code from the version linked in the Download page and that zip file did not contain configure file

[fklassen]

Just download the release https://github.com/appneta/tcpreplay/releases/tag/v4.5.1

[resolutedreamer]

Yes sir, I went to the exact same URL that you provided, and I clicked on the "Source code (zip)" button.

And then after opening the downloaded file, the contents of the zip appeared as follows

Which does not contain a configure file.