New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] 修复Client-Monitor存在的问题 #85

Open

Rawven opened this issue Oct 19, 2024 · 0 comments · May be fixed by #86

Contributor

Rawven commented Oct 19, 2024 •

edited

Loading

背景
我是该PR的作者 [OSPP]Add more observability in apollo config client #74,
在PR合并后我开始进行除自己编写的测试用例外更多的测试，如在apollo-demo-java和apollo-use-cases,随后便发现了一些用户体验不足的地方，

在开启Monitor的情况下如果用户不配置apollo.client.monitor.external.type,将会在应用启动时打印一次表明没有启用MetricsExporter的日志，日志冗余

处理：处理无启用的情况下不打印日志
部分依托客户端运行中刷新的监控参数没有设置默认值导致过早调用其状态会报空指针
如 metaFreshTime时若在第一次触发该函数前调用ApolloClientBootstrapArgsMonitorApi.getMetaFreshTime()会报空

处理：设置默认值
PrometheusApolloClientMetricsExporter的logger配置错误
ConfigMonitor的接口命名和实际API不统一问题

我会在之后的时间持续测试，直到该功能稳定且有一个良好的用户体验，最终我会提交PR

Rawven linked a pull request

that will close this issue

Fix/monitor #86

Open

4 tasks

Rawven changed the title ~~[Enhance] 增强Client-Monitor的用户体验~~ [bug] 修复Client-Monitor存在的问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment