Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regex search for the submitted form contents #87

Closed
markkuriekkinen opened this issue Sep 14, 2023 · 0 comments · Fixed by #107
Closed

Add regex search for the submitted form contents #87

markkuriekkinen opened this issue Sep 14, 2023 · 0 comments · Fixed by #107
Assignees
@etanttila
Labels
area: UX teacher User experience and usability for teachers effort: days Estimated to take less than one week, from creation of a new branch to the merging priority: medium requester: Aalto teacher
Milestone
User experience r...

Comments

@markkuriekkinen
Copy link
Contributor

From the closed issue #42:

#42 (comment)

Based on my experiences, the regex search now works for modules (exercise identifier) but not for form contents. (The symptom is that nothing is found — there’s no error message.)

#42 (comment)

That is correct, the regex search was implemented for exercise identifiers but not for form contents during the summer. We discussed that for the form content, it would be difficult to have a search which supports both regex searches and normal searches (where word order doesn't matter, etc.), and I understood that if needed to decide between the two, it was preferred to have normal searches (with boolean operators). Thus there is no support for regex searches for the form contents.

That was one of the reasons why I didn't mark this issue as solved in any commits or the PR #59 (in them, I indicated that they partially fix this issue). Markku afterwards closed this issue. If regex search for the form content search is wanted, I would recommend making a new separate issue (as was done for #68).
@markkuriekkinen markkuriekkinen added requester: Aalto teacher area: UX teacher User experience and usability for teachers effort: days Estimated to take less than one week, from creation of a new branch to the merging labels Sep 14, 2023
@markkuriekkinen markkuriekkinen mentioned this issue Sep 14, 2023
Closed
etanttila added a commit to etanttila/mooc-jutut that referenced this issue Jun 4, 2024
@etanttila
Add regex search option for text searches
13f5d6f 
Allow user to select to use regex search for student form contents
and teacher response. This is done by checking a checkbox by the field.
Implement filter, field and widget that allow selecteing between default
search method and a regex search.
Implement simple validation and error handling (also for exercise identifier,
which didn't validate regex) for regex.
Change form styling to use flex, so the checkbox and label can also be
positioned well.

Fix apluslms#87
@etanttila etanttila mentioned this issue Jun 4, 2024
Merged
18 tasks
etanttila added a commit to etanttila/mooc-jutut that referenced this issue Jun 4, 2024
@etanttila
Add regex search option for text searches
b14475c 
Allow user to select to use regex search for student form contents
and teacher response. This is done by checking a checkbox by the field.
Implement filter, field and widget that allow selecting between default
search method and a regex search.
Implement simple validation and error handling (also for exercise identifier,
which didn't validate regex) for regex.
Change form styling to use flex, so the checkbox and label can also be
positioned well.

Fix apluslms#87
@etanttila etanttila self-assigned this Jun 4, 2024
etanttila added a commit to etanttila/mooc-jutut that referenced this issue Jul 3, 2024
@etanttila
Add regex search option for text searches
90a51aa 
Allow user to select to use regex search for student form contents
and teacher response. This is done by checking a checkbox by the field.
Implement filter, field and widget that allow selecting between default
search method and a regex search.
Implement simple validation and error handling (also for exercise identifier,
which didn't validate regex) for regex.
Change form styling to use flex, so the checkbox and label can also be
positioned well.

Fix apluslms#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etanttila etanttila

Labels
area: UX teacher User experience and usability for teachers effort: days Estimated to take less than one week, from creation of a new branch to the merging priority: medium requester: Aalto teacher
Projects
A+ sprints
Status: Done
Milestone
User experience revamp
Development

Successfully merging a pull request may close this issue.

Add regex search option for text searches etanttila/mooc-jutut
2 participants
@markkuriekkinen @etanttila