-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ionic package build - can only have default settings #126
Comments
A workaround would probably include finding another plugin that does something like what this (Idea: Maybe you can make app-settings part of your |
Thanks @piotrowski. I think if the app-settings.json file were located in the src folder it would get uploaded to ionic package service; however, that service uses the npm version not local version of Cordova plugins, so I can't modify the plugin to read the settings from another location. I could create a hook in settings.xml that copies the file to where the plugin expects it, but ionic package system doesn't allow custom hooks. I would have to submit the hook to ionic for possible inclusion into their repository of approved hooks. Maybe this plugin could read the location of the app-settings.json file from the settings.xml file and use the root as a default, preventing this from being a breaking change. That all said, I've completed the project I was working on without the app preferences. I was just putting this out here hoping someone with more experience with ionic package and Cordova had figured out something that already works. If I do another project that requires app preferences, and we still don't have a Mac, I'll create a pull request to set the location of the app-preferences.json in the settings.xml file. |
You would fork the plugin, make your changes, install the forked version in your project so Ionic Package would also use this adapted version of the plugin. |
From what I understand Ionic Package won't use local version's of Cordova plugins, but pulls it down from npm based on it being referenced in your settings.xml. I'll test that idea and see how it goes, but I think the changes won't be recognized by ionic package service. |
Ahh, most people don't know this but by using your Github URL when installing ( |
OMG, thanks for that tip. Exactly why I was posting something out here. Hoping someone who knows more about this system would have a great suggestion like that. |
Issue:
This is a great plugin, but I think it will not work with ionic package build service. I have updated app-settings.json, run cordova prepare, verified the output in platforms/ios/Settings.bundle but whenever I run ionic package build ios I always get an ipa with the the Title/Language/Debug settings shipped with the plugin. I don't believe there is anything this plugin can do either. The ionic build system does not upload local plugins, but uploads the config.xml and uses their version of the plugins. I believe the app-settings.json file is not uploaded, so this plugin during the prepare uses the default's shipped with the plugin. If anyone knows a way to workaround this that would be awesome, but otherwise I'm more or less just adding this here for the next schmuck who wastes a day and a half trying to get this to work.
Please specify your environment
Plugin version:
Toolchain:
Platforms affected:
What the scope of your problem:
The text was updated successfully, but these errors were encountered: