Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WithTraceAt() method to adjust Trace() log level #101

Closed
wants to merge 1 commit into from

Conversation

sjbarag
Copy link

@sjbarag sjbarag commented Apr 16, 2022

Hey @tj! I'm loving Apex's log module so far, and figured I'd take a crack at adding a method to allow .Trace() and .Stop() to log non-errors at a configurable level. I'm happy to rename that method as well — let me know what feels right to you :)


The Trace() and Stop() methods for an Entry default to Info-level logging, and previously didn't offer a way to log non-errors at any other level. Add a WithTraceAt() method to allow that level to be configured.

fixes #93

The Trace() and Stop() methods for an Entry default to Info-level
logging, and previously didn't offer a way to log non-errors at any
other level. Add a WithTraceAt() method to allow that level to be
configured.

fixes apex#93
@sjbarag
Copy link
Author

sjbarag commented Dec 10, 2024

Doing some cleanup of my open (and likely stale) PRs, so I'm going to close this.

@sjbarag sjbarag closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The level of logging for Trace should not be locked to Info.
1 participant