Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of error.h in mod_auth_cas.c #117

Open
kinghuang opened this issue Oct 31, 2016 · 3 comments · May be fixed by #119
Open

Use of error.h in mod_auth_cas.c #117

kinghuang opened this issue Oct 31, 2016 · 3 comments · May be fixed by #119

Comments

@kinghuang
Copy link

I'm having a tough time building mod_auth_cas on httpd:2.4.23-alpine (Alpine Linux), as opposed to httpd:2.4.23 (Debian). mod_auth_cas.c imports <error.h>, which isn't provided by musl/libc-dev on Alpine.

Is error.h strictly needed? I scanned through mod_auth_cas.c, but couldn't find an obvious use of it.
@pames
Copy link
Contributor

pames commented Oct 31, 2016

I believe it's used for errno.

@kinghuang
Copy link
Author

errno.h does exist for both Debian and Alpine, and can be imported specifically. It doesn't look like error.h imports errno.h, directly or indirectly.

I've commented out #include <error.h> to complete the build on Alpine with no immediate ill effects. If nothing goes wrong in local testing, I'll submit a PR.

@dgeo
Copy link

dgeo commented Dec 10, 2016

same kind of error under FreeBSD:

mod_auth_cas.c:25:10: fatal error: 'error.h' file not found
#include <error.h>
         ^
1 error generated.
apxs:Error: Command failed with rc=65536

dgeo added a commit to criecm/mod_auth_cas that referenced this issue Dec 10, 2016
@dgeo
use error.h *only if it exists*
10300a1 
fixes apereo#117
@dgeo dgeo linked a pull request Dec 10, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use error.h *only if it exists* criecm/mod_auth_cas
3 participants
@kinghuang @dgeo @pames