Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Network Error Messages on Filter Bars and Charts #31342

Closed
yousoph opened this issue Dec 9, 2024 · 4 comments · Fixed by #31811
Closed

Update Network Error Messages on Filter Bars and Charts #31342

yousoph opened this issue Dec 9, 2024 · 4 comments · Fixed by #31811
Assignees
Labels
dashboard:design Related to the Dashboard UI/UX preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached. viz:charts Namespace | Anything related to viz types

Comments

@yousoph
Copy link
Member

yousoph commented Dec 9, 2024

Screenshot

image

Chart error details:

image

Description

When a user is disconnected from the internet, they see errors like the ones in the screenshot above.

Changes to the chart error message:

  • Warning icon is missing
  • Message should be red (like the filter errors)
  • Error message title in both the chart and the modal should be "Network error" rather than "Unexpected error"
  • Description in the error modal should read "Network Error when attempting to load chart. Please check your internet connection and try again."

For ALL filter errors (including this one but also any others):

  • Rather than showing the full error message, just show the title in the filter bar
  • Details of the error should appear in the tooltip on hover
  • If possible, filter error should mimic the size of the select field
  • Height of the banner should be one line (the rest truncated)
    image
    image

Changes to the filter bar errors:

  • Update title to "Network error"
  • If the copy "Network error" doesn't fit in one line, remove the ! icon to get the text to fit in a single line
  • Update description to "Network Error when attempting to load resource. Please check your internet connection and try again."

Design input

Please tag @kasiazjc for additional questions/clarifications if needed

@dosubot dosubot bot added dashboard:design Related to the Dashboard UI/UX viz:charts Namespace | Anything related to viz types labels Dec 9, 2024
@geido
Copy link
Member

geido commented Jan 9, 2025


🎉 Preset Bounty Available: $250 USD 🎉

To claim this bounty, please carefully follow the steps below.


📋 Steps to Participate

  1. Review Guidelines:
    Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

  2. Show Your Interest:
    Complete the Preset Bounty Program Survey and comment this issue to express your interest.

  3. Join the Slack Channel:
    After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

  4. Get Assigned:
    To officially start, ensure a Bounty Program Manager has assigned you to this issue.

  5. Submit Your Solution:
    When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

  6. Claim Your Bounty:
    Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/1038


💡 Additional Notes

  • Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
  • Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. labels Jan 9, 2025
@msyavuz
Copy link
Contributor

msyavuz commented Jan 9, 2025

Can i work on this?

@LevisNgigi
Copy link
Contributor

Hey @geido can I take this?

@syedbarimanjan
Copy link

@geido I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:design Related to the Dashboard UI/UX preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached. viz:charts Namespace | Anything related to viz types
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@yousoph @geido @msyavuz @LevisNgigi @syedbarimanjan and others