Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Modernize Labels #12296

Open
2 of 3 tasks
hanahmily opened this issue Jun 5, 2024 · 1 comment
Open
2 of 3 tasks

[Helm] Modernize Labels #12296

hanahmily opened this issue Jun 5, 2024 · 1 comment
Labels
feature New feature helm Helm in skywalking-kubernetes
Milestone

Comments

@hanahmily
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

SkyWalking and BanyanDB Helm Chart adhere to a legacy label style from Helm 2. We should update them by referencing https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/.

Use case

No response

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@hanahmily hanahmily added feature New feature helm Helm in skywalking-kubernetes labels Jun 5, 2024
@hanahmily hanahmily added this to the Helm - 4.7.0 milestone Jun 5, 2024
@wu-sheng wu-sheng modified the milestones: Helm - 4.7.0, Helm - 4.8.0 Oct 13, 2024
@wu-sheng
Copy link
Member

wu-sheng commented Oct 13, 2024

BanyanDB side is fixed by apache/skywalking-banyandb-helm#21 (banyandb helm 0.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature helm Helm in skywalking-kubernetes
Projects
None yet
Development

No branches or pull requests

2 participants