Sharing or Sharding?

[thadguidry]

I noticed in the code that sometimes "sharding" and "sharing" are used interchangeably? Was this intentional? Or should "sharing" be replaced by "sharding"?

[strongduanmu]

Can you give some example? Maybe it's a typo.

[thadguidry]

I basically searched for "sharing" using this GitHub search , which returned 42 files and saw that sometimes in those files the context might be correct, and sometimes the context might instead correctly be "sharding"? So maybe sometimes in some of the lines of the files, indeed, it might be a typo that needs to be fixed, depending on the correct context that was meant?

A few examples:

1. shardingsphere/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/yaml/config/strategy/audit/YamlShardingAuditStrategyConfiguration.java

   Line 27 in 0c5f63a

   * Sharing audit strategy configuration for YAML.

2. shardingsphere/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/exception/metadata/DuplicateSharingActualDataNodeException.java

   Line 26 in 0c5f63a

   public final class DuplicateSharingActualDataNodeException extends ShardingSQLException {

3. shardingsphere/docs/document/content/user-manual/common-config/builtin-algorithm/sharding.en.md

   Line 122 in 0c5f63a

   | sharding-columns (?) | String | sharing column names | - |

4. shardingsphere/features/sharding/distsql/handler/src/main/java/org/apache/shardingsphere/sharding/distsql/handler/checker/ShardingTableRuleStatementChecker.java

   Line 90 in 0c5f63a

   * Check create sharing table rule statement.

5. shardingsphere/test/it/parser/src/main/resources/sql/supported/ddl/create-table.xml

   Line 36 in 0c5f63a

   <sql-case id="create_table_with_sharing_metadata" value="CREATE TABLE t_log SHARING = METADATA (id int PRIMARY KEY, status varchar(10))" db-types="Oracle" />

but there were more. But I'm not sure if/when "sharing" or "sharding" was intended.
Hopefully the team can sort it out and do a thorough cleanup and replacement of the correct context word to use where it's needed.

[strongduanmu]

@thadguidry Thank you for pointing this out, it is indeed a typo, I will check this and fix it.

[strongduanmu]

I fixed the sharing typo in #33132, thanks again for raising the issue.