Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Namesrv laod config wired bug #8913

Open
3 tasks done
TianMing2018 opened this issue Nov 13, 2024 · 0 comments
Open
3 tasks done

[Bug] Namesrv laod config wired bug #8913

TianMing2018 opened this issue Nov 13, 2024 · 0 comments

Comments

@TianMing2018
Copy link
Contributor

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Windows 10 ltsc

RocketMQ version

5.1.3

JDK Version

PS E:\rocketmq-all-5.3.1-bin-release\bin> java --version
openjdk 21.0.1 2023-10-17 LTS
OpenJDK Runtime Environment (build 21.0.1+12-LTS)
OpenJDK 64-Bit Server VM (build 21.0.1+12-LTS, mixed mode, sharing)

Describe the Bug

when I run this command : .\mqnamesrv.cmd -c C:\Users\lsZ\namesrv\namesrv.conf, things going unlike what It should be

  1. no matter to use namesrv.conf or namesrv.properties , even those config file contains syntax problem , the program always print like this: 
       load config properties file OK, C:\Users\lsZ\namesrv\namesrv.conf
    The Name Server boot success. serializeType=JSON, address 0.0.0.0:9876
  2. use .\mqnamesrv.cmd -p ,printed log always was that , I don't khonw my customized paramerter worked 
     PS E:\rocketmq-all-5.3.1-bin-release\bin> .\mqnamesrv -p
2024-11-13 11:00:36 INFO main - rocketmqHome=E:\rocketmq-all-5.3.1-bin-release
2024-11-13 11:00:36 INFO main - kvConfigPath=C:\Users\lsZ\namesrv\kvConfig.json
2024-11-13 11:00:36 INFO main - configStorePath=C:\Users\lsZ\namesrv\namesrv.properties
2024-11-13 11:00:36 INFO main - productEnvName=center
2024-11-13 11:00:36 INFO main - clusterTest=false
2024-11-13 11:00:36 INFO main - orderMessageEnable=false
2024-11-13 11:00:36 INFO main - returnOrderTopicConfigToBroker=true
2024-11-13 11:00:36 INFO main - clientRequestThreadPoolNums=8
2024-11-13 11:00:36 INFO main - defaultThreadPoolNums=16
2024-11-13 11:00:36 INFO main - clientRequestThreadPoolQueueCapacity=50000
2024-11-13 11:00:36 INFO main - defaultThreadPoolQueueCapacity=10000
2024-11-13 11:00:36 INFO main - scanNotActiveBrokerInterval=5000
2024-11-13 11:00:36 INFO main - unRegisterBrokerQueueCapacity=3000
2024-11-13 11:00:36 INFO main - supportActingMaster=false
2024-11-13 11:00:36 INFO main - enableAllTopicList=true
2024-11-13 11:00:36 INFO main - enableTopicList=true
2024-11-13 11:00:36 INFO main - notifyMinBrokerIdChanged=false
2024-11-13 11:00:36 INFO main - enableControllerInNamesrv=false
2024-11-13 11:00:36 INFO main - needWaitForService=false
2024-11-13 11:00:36 INFO main - waitSecondsForService=45
2024-11-13 11:00:36 INFO main - deleteTopicWithBrokerRegistration=false
2024-11-13 11:00:36 INFO main - configBlackList=configBlackList;configStorePath;kvConfigPath
2024-11-13 11:00:36 INFO main - bindAddress=0.0.0.0
2024-11-13 11:00:36 INFO main - listenPort=9876
2024-11-13 11:00:36 INFO main - serverWorkerThreads=8
2024-11-13 11:00:36 INFO main - serverCallbackExecutorThreads=0
2024-11-13 11:00:36 INFO main - serverSelectorThreads=3
2024-11-13 11:00:36 INFO main - serverOnewaySemaphoreValue=256
2024-11-13 11:00:36 INFO main - serverAsyncSemaphoreValue=64
2024-11-13 11:00:36 INFO main - serverChannelMaxIdleTimeSeconds=120
2024-11-13 11:00:36 INFO main - serverSocketSndBufSize=0
2024-11-13 11:00:36 INFO main - serverSocketRcvBufSize=0
2024-11-13 11:00:36 INFO main - writeBufferHighWaterMark=0
2024-11-13 11:00:36 INFO main - writeBufferLowWaterMark=0
2024-11-13 11:00:36 INFO main - serverSocketBacklog=1024
2024-11-13 11:00:36 INFO main - serverNettyWorkerGroupEnable=true
2024-11-13 11:00:36 INFO main - serverPooledByteBufAllocatorEnable=true
2024-11-13 11:00:36 INFO main - enableShutdownGracefully=false
2024-11-13 11:00:36 INFO main - shutdownWaitTimeSeconds=30
2024-11-13 11:00:36 INFO main - useEpollNativeSelector=false
2024-11-13 11:00:36 INFO main - clientWorkerThreads=4
2024-11-13 11:00:36 INFO main - clientCallbackExecutorThreads=14
2024-11-13 11:00:36 INFO main - clientOnewaySemaphoreValue=65535
2024-11-13 11:00:36 INFO main - clientAsyncSemaphoreValue=65535
2024-11-13 11:00:36 INFO main - connectTimeoutMillis=3000
2024-11-13 11:00:36 INFO main - channelNotActiveInterval=60000
2024-11-13 11:00:36 INFO main - isScanAvailableNameSrv=true
2024-11-13 11:00:36 INFO main - clientChannelMaxIdleTimeSeconds=120
2024-11-13 11:00:36 INFO main - clientSocketSndBufSize=0
2024-11-13 11:00:36 INFO main - clientSocketRcvBufSize=0
2024-11-13 11:00:36 INFO main - clientPooledByteBufAllocatorEnable=false
2024-11-13 11:00:36 INFO main - clientCloseSocketIfTimeout=true
2024-11-13 11:00:36 INFO main - useTLS=false
2024-11-13 11:00:36 INFO main - socksProxyConfig={}
2024-11-13 11:00:36 INFO main - writeBufferHighWaterMark=0
2024-11-13 11:00:36 INFO main - writeBufferLowWaterMark=0
2024-11-13 11:00:36 INFO main - disableCallbackExecutor=false
2024-11-13 11:00:36 INFO main - disableNettyWorkerGroup=false
2024-11-13 11:00:36 INFO main - maxReconnectIntervalTimeSeconds=60
2024-11-13 11:00:36 INFO main - enableReconnectForGoAway=true
2024-11-13 11:00:36 INFO main - enableTransparentRetry=true
"Namesrv starts OK"
  3. here is my config file, namesrv.conf almost sames with namesrv.properties, the only difference is = replaced to = 
    clusterTest=FALSE
configStorePath=C:\Users\lsZ\namesrv\namesrv.properties
kvConfigPath=C:\Users\lsZ\namesrv\namesrv\kvConfig.json
orderMessageEnable=TRUE
rocketmqHome=E:\rocketmq-all-5.3.1-bin-release

channelNotActiveInterval=60000
clientAsyncSemaphoreValue=65535
clientCallbackExecutorThreads=4
clientChannelMaxIdleTimeSeconds=120
clientCloseSocketIfTimeout=TRUE
clientOnewaySemaphoreValue=65535
clientPooledByteBufAllocatorEnable=FALSE
clientSocketRcvBufSize=0
clientSocketSndBufSize=0
clientWorkerThreads=4
connectTimeoutMillis=3000

bindAddress=0.0.0.0 
clientRequestThreadPoolNums=8 
clientRequestThreadPoolQueueCapacity=50000 
configBlackList=configBlackList;configStorePath;kvConfigPath 
defaultThreadPoolNums=16 
defaultThreadPoolQueueCapacity=10000 
deleteTopicWithBrokerRegistration=FALSE 
disableCallbackExecutor=FALSE 
disableNettyWorkerGroup=FALSE 
enableAllTopicList=TRUE 
enableControllerInNamesrv=FALSE 
enableReconnectForGoAway=TRUE 
enableShutdownGracefully=FALSE 
enableTopicList=TRUE 
enableTransparentRetry=TRUE 
isScanAvailableNameSrv=TRUE 
listenPort=9876 
maxReconnectIntervalTimeSeconds=60 
needWaitForService=FALSE 
notifyMinBrokerIdChanged=FALSE 
productEnvName=center 
returnOrderTopicConfigToBroker=TRUE 
scanNotActiveBrokerInterval=5000 
serverAsyncSemaphoreValue=64 
serverCallbackExecutorThreads=0 
serverChannelMaxIdleTimeSeconds=120 
serverNettyWorkerGroupEnable=TRUE 
serverOnewaySemaphoreValue=256 
serverPooledByteBufAllocatorEnable=TRUE 
serverSelectorThreads=3 
serverSocketBacklog=1024 
serverSocketRcvBufSize=0 
serverSocketSndBufSize=0 
serverWorkerThreads=8 
shutdownWaitTimeSeconds=30 
socksProxyConfig={} 
supportActingMaster=FALSE 
unRegisterBrokerQueueCapacity=3000 
useEpollNativeSelector=FALSE 
useTLS=FALSE 
waitSecondsForService=45 
writeBufferHighWaterMark=0 
writeBufferLowWaterMark=0

I had swap configStorePath to C:\Users\lsZ\namesrv\namesrv.properties in namesrv.conf , and namesrv.propertiestoo. I had replaced` with \\ or //、 TRUE to true 、FALSE to false
I had deleted empty line
Howevevr, I still can't set orderMessageEnable to true

Steps to Reproduce

see the description and use my config file to run like this

  1. press .\mqnamesrv.cmd -c C:\Users\lsZ\namesrv\namesrv.conf
  2. press .\mqnamesrv.cmd -p
  3. check orderMessageEnable value ,it should be false, just like this issue

What Did You Expect to See?

       ```console
  PS E:\rocketmq-all-5.3.1-bin-release\bin> .\mqnamesrv -p
2024-11-13 11:00:36 INFO main - rocketmqHome=E:\rocketmq-all-5.3.1-bin-release
2024-11-13 11:00:36 INFO main - kvConfigPath= ${your customized location}
2024-11-13 11:00:36 INFO main - configStorePath=${your customized location}
    ........................
2024-11-13 11:00:36 INFO main - orderMessageEnable=${your customized value}
    .......................
"Namesrv starts OK"
```
  1. when you pass config file args: check your config file , exit when your config file with syntax problems and print invalid item
  2. fixed config file don't workd issue
  3. update namesrv config item docs and namesrv -p reuslt, they sholud sames with each other
  4. add description in this repo or rocketme-site , describe how to customize namesrv config， and which parameter we can customized
  5. if we want to send orderly message, do we need to set orderMessageEnable in namesrv ? why nobody mentioned this issue?

What Did You See Instead?

  ```console
  PS E:\rocketmq-all-5.3.1-bin-release\bin> .\mqnamesrv -p
2024-11-13 11:00:36 INFO main - rocketmqHome=E:\rocketmq-all-5.3.1-bin-release
2024-11-13 11:00:36 INFO main - kvConfigPath=C:\Users\lsZ\namesrv\kvConfig.json
2024-11-13 11:00:36 INFO main - configStorePath=C:\Users\lsZ\namesrv\namesrv.properties
    ........................
2024-11-13 11:00:36 INFO main - orderMessageEnable=false
    .......................
"Namesrv starts OK"
```

Additional Context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TianMing2018