Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Pagination is not working for List namespaces #147

Open
1 task done
shraddhagrawal opened this issue Aug 13, 2024 · 1 comment · May be fixed by #273
Open
1 task done

[BUG]Pagination is not working for List namespaces #147

shraddhagrawal opened this issue Aug 13, 2024 · 1 comment · May be fixed by #273
Labels
bug Something isn't working enhancement New feature or request

Comments

@shraddhagrawal
Copy link

Is this a possible security vulnerability?

  • This is NOT a possible security vulnerability

Describe the bug

Even if we specify page size api is returning all namespaces
In docs it is mentioned "servers that support pagination" can you please elaborate what this means?

To Reproduce

curl --location 'http://localhost:8181/api/catalog/v1/polaris/namespaces?parent=accounting&pageSize=1&pageToken=null'
--header 'Authorization: Bearer principal:root;password:xxxxxxxxxxxxxxxx;realm:default-realm;role:ALL'
--data ''

Actual Behavior

returned all namespaces

Expected Behavior

return only one namespace

Additional context

No response

System information

No response

@shraddhagrawal shraddhagrawal added the bug Something isn't working label Aug 13, 2024
@ebyhr
Copy link
Contributor

ebyhr commented Aug 14, 2024

Polaris doesn't support pagination yet in my understanding. You can see pageToken and pageSize parameters are unused:

https://github.com/polaris-catalog/polaris/blob/167f71bf9ce33cb9cda24c8ebb8a8a00bd19a367/polaris-service/src/main/java/io/polaris/service/catalog/IcebergCatalogAdapter.java#L117-L128

@flyrain flyrain added the enhancement New feature or request label Aug 15, 2024
@flyrain flyrain moved this to Triage in Basic Kanban Board Aug 15, 2024
@eric-maynard eric-maynard linked a pull request Sep 6, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants