[flink] Bugfix expire snapshot don't work when some snapshot between earliest and latest are removed for some reason

jiangqiao.xu · jiangqiao.xu · commit 7691d1fa2750 · 2024-12-20T19:26:58.000+08:00
diff --git a/paimon-core/src/main/java/org/apache/paimon/table/ExpireSnapshotsImpl.java b/paimon-core/src/main/java/org/apache/paimon/table/ExpireSnapshotsImpl.java
@@ -120,7 +120,7 @@ public int expire() {
             // Ensure maxExclusive exist, deal some snapshot between earliest and latest is deleted
             maxExclusiveByExpireLimit++;
         }
-        maxExclusive = Math.min(maxExclusive, maxExclusiveByExpireLimit);
+        maxExclusive = Math.min(maxExclusive, earliest + maxDeletes);
 
         for (long id = min; id < maxExclusive; id++) {
             // Early exit the loop for 'snapshot.time-retained'

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public int expire() {`
`120`	`120`	`// Ensure maxExclusive exist, deal some snapshot between earliest and latest is deleted`
`121`	`121`	`maxExclusiveByExpireLimit++;`
`122`	`122`	`}`
`123`		`- maxExclusive = Math.min(maxExclusive, maxExclusiveByExpireLimit);`
	`123`	`+ maxExclusive = Math.min(maxExclusive, earliest + maxDeletes);`
`124`	`124`
`125`	`125`	`for (long id = min; id < maxExclusive; id++) {`
`126`	`126`	`// Early exit the loop for 'snapshot.time-retained'`