Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSL] Unused tooltip is not shown #8102

Closed
junichi11 opened this issue Dec 31, 2024 · 3 comments · Fixed by #8103
Closed

[CSL] Unused tooltip is not shown #8102

junichi11 opened this issue Dec 31, 2024 · 3 comments · Fixed by #8103
Assignees
@lkishalmi
Labels
CSL [ci] enable web job kind:bug Bug report or fix Regression This used to work!
Milestone
NB25

Comments

@junichi11
Copy link
Member

junichi11 commented Dec 31, 2024 •
edited
Loading

Apache NetBeans version

Apache NetBeans latest daily build

What happened

Unused tooltip is not shown.
Probably, after this change: #8028

NetBeans 24:

nb-csl-unused-tooltip-before

master branch:

nb-csl-unused-tooltip-after

Language / Project Type / NetBeans Component

CSL

How to reproduce

  1. Create a PHP project
  2. Create a new PHP file
  3. Write the following code
<?php
class Test {
    private int $privateField = 1;
}

Did this work correctly in an earlier version?

Apache NetBeans 24

Operating System

Ubuntu 22.04

JDK

OpenJDK 19

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

No response

Are you willing to submit a pull request?

No
@junichi11 junichi11 added kind:bug Bug report or fix CSL [ci] enable web job needs:triage Requires attention from one of the committers Regression This used to work! labels Dec 31, 2024
@matthiasblaesing matthiasblaesing removed the needs:triage Requires attention from one of the committers label Dec 31, 2024
@matthiasblaesing
Copy link
Contributor

Verified:

  • Problem can be observed in 0ba2e7a
  • Problem is not present in 1261641

@matthiasblaesing matthiasblaesing mentioned this issue Dec 31, 2024
Merged
@lkishalmi lkishalmi self-assigned this Dec 31, 2024
@lkishalmi
Copy link
Contributor

Could be something with the weak references. some of the unused tooltips are actually displayed, usually just once, then they are gone.

matthiasblaesing added a commit to matthiasblaesing/netbeans that referenced this issue Dec 31, 2024
@matthiasblaesing
csl.api: Fix GsfSemanticLayer after 0ba2e7a
40467c8 
The implementation of GsfSemanticLayer#firstSequenceElement returns
wrong/out-of-range values for the first element. This in turn causes
tooltip/rendering errors when the sequence is used/positioned.

Closes: apache#8102
@matthiasblaesing matthiasblaesing mentioned this issue Dec 31, 2024
Merged
@matthiasblaesing
Copy link
Contributor

Please have a look at #8103. I fixed firstSequenceElement and added a unittest to verify the behavior.

matthiasblaesing added a commit that referenced this issue Jan 1, 2025
@matthiasblaesing
Merge pull request #8103 from matthiasblaesing/gh-8102
59bea23 
csl.api: Fix GsfSemanticLayer after 0ba2e7a
@junichi11 junichi11 added this to the NB25 milestone Jan 1, 2025
jhorvath pushed a commit to jhorvath/netbeans that referenced this issue Jan 10, 2025
@matthiasblaesing @jhorvath
csl.api: Fix GsfSemanticLayer after 0ba2e7a
2c5c2a2 
The implementation of GsfSemanticLayer#firstSequenceElement returns
wrong/out-of-range values for the first element. This in turn causes
tooltip/rendering errors when the sequence is used/positioned.

Closes: apache#8102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lkishalmi lkishalmi

Labels
CSL [ci] enable web job kind:bug Bug report or fix Regression This used to work!
Projects
None yet
Milestone
NB25
3 participants
@junichi11 @lkishalmi @matthiasblaesing