Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update center from java.lsp.server/build.xml #8077

Open
MartinBalin opened this issue Dec 19, 2024 · 1 comment
Open

Remove update center from java.lsp.server/build.xml #8077

MartinBalin opened this issue Dec 19, 2024 · 1 comment
Assignees
Labels
kind:bug Bug report or fix VSCode Extension [ci] enable VSCode Extension tests

Comments

@MartinBalin
Copy link
Contributor

Apache NetBeans version

Apache NetBeans 24

What happened

Remove hard coded updatecenter="https://netbeans.apache.org/nb/plugins/17/catalog.xml.gz"> from java.lsp.server/build.xml
It is not really being used by VSNetBeans build, it could be preserved but allow to pass it as param. Even better can be to use a direct link to the Maven download, or a catalog.xml in the sources with a direct link to the Maven file.

Language / Project Type / NetBeans Component

VSNetBeans Build

How to reproduce

build with passing in name of some 3rd party module from update center

Did this work correctly in an earlier version?

No / Don't know

Operating System

any

JDK

any

Apache NetBeans packaging

Apache VSNetBeans for VSCode

Anything else

No response

Are you willing to submit a pull request?

No

@MartinBalin MartinBalin added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Dec 19, 2024
@MartinBalin MartinBalin self-assigned this Dec 19, 2024
@MartinBalin MartinBalin added VSCode Extension [ci] enable VSCode Extension tests and removed needs:triage Requires attention from one of the committers labels Dec 19, 2024
@MartinBalin
Copy link
Contributor Author

Change CI Job https://github.com/apache/netbeans/actions/runs/12350872504/job/34465121290#logs VSCode Extenstion test on jdk17 is still requiring to install externalcodeformatter plugin. likely by passing it there in command line for run, see https://productionresultssa16.blob.core.windows.net/actions-results/7757e860-3c26-48ee-bee5-5da233[…]&sr=b&st=2024-12-18T08%3A46%3A58Z&sv=2024-11-04

2024-12-16T10:48:53.5279405Z ##[group]Run cd java/java.lsp.server
2024-12-16T10:48:53.5279944Z [36;1mcd java/java.lsp.server[0m
2024-12-16T10:48:53.5280567Z [36;1mant $OPTS build-vscode-ext -D3rdparty.modules=.*externalcodeformatter.*[0m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Bug report or fix VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

No branches or pull requests

1 participant