CSS: Fix parsing of @keyframes rules #8053
Open
+13,582
−13,147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
added
CSS
Before 23ed111 "CSS: Improve handling of generic-at-rules (for example used by tailwind)" the CSS parser returned the body of generic @-rules as a plain list of tokens. That changed and the @Keyframes rule needs to be special cased. There was already a special case for the @-webkit-keyframes variant, which is identical to the final variant and differs only in the introducing rule name. The vendored variants @-moz-keyframes and @-o-keyframes are also supported. Closes: apache#8052
matthiasblaesing
force-pushed
the
keyframes
branch
from
60bd919 to
abf6ceb
Compare
|
I intent to merge this before christmas, so if you want me to wait, speak now please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 23ed111 "CSS: Improve handling of generic-at-rules (for example used by tailwind)" the CSS parser returned the body of generic @-rules as a plain list of tokens. That changed and the @Keyframes rule needs to be special cased. There was already a special case for the @-webkit-keyframes variant, which is identical to the final variant and differs only in the introducing rule name.
Closes: #8052