Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output window: better warning color for FlatLaf light #7913

Merged
merged 1 commit into from
Nov 5, 2024
Merged

output window: better warning color for FlatLaf light #7913

merged 1 commit into from
Nov 5, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 26, 2024 •
edited
Loading

current default is often hard to read on white background

before (Color.ORANGE):
image

after:
image

fixes #7911

targets delivery since trivial

@mbien
output window: better warning color for FlatLaf light
86df6fa 
current default is often hard to read on white background
@mbien mbien added Look and Feel ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Oct 26, 2024
@mbien mbien added this to the NB24 milestone Oct 26, 2024
@mbien mbien linked an issue Oct 26, 2024 that may be closed by this pull request
Fix problem with palette in output window #7911
Closed
matthiasblaesing
matthiasblaesing approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. The contrast does not only look higher, according to FF accessibility checker it is indeed. Not sure whether I would have targetted it to delivery, but it is low risk and we'll have more RCs.

@mbien
Copy link
Member Author

mbien commented Oct 29, 2024

i forgot to mention that I tried other colors too, see #7911 (comment) for screenshots.

Even darker orange had the problem to be too similar to red if they are closer together - so this is a compromise.

@ebarboni ebarboni merged commit 2669fd6 into apache:delivery Nov 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Look and Feel
Projects
None yet
Milestone
NB24
Development

Successfully merging this pull request may close these issues.

Fix problem with palette in output window
3 participants
@mbien @matthiasblaesing @ebarboni