Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed) #3369

Open
JWT007 opened this issue Jan 7, 2025 · 2 comments

Comments

@JWT007
Copy link
Contributor

JWT007 commented Jan 7, 2025

Log4j 2.24

In LoggerConfig.Builder, an original typo existed in the 'withtFilter' method (extra 't' in name).

This was fixed by deprecating the original method and adding the correct 'withFilter' method.

        /**  @deprecated Use {@link #withFilter(Filter)} instead  */
        @Deprecated
        public B withtFilter(final Filter filter) { ... }

        public B withFilter(final Filter filter) { ... }

However, it was not fixed in the nested LoggerConfig.RootLogger.Builder implementation - there the name is still incorrect.

The nested builder method should also be deprecated and 'withFilter' added to replace it with the correct name.

@JWT007 JWT007 changed the title LoggerConfig.RootLogger.Builder#withtFilter (typo in metthod name / only partially fixed) LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed) Jan 7, 2025
@ppkarwasz
Copy link
Contributor

@JWT007,

Thanks! Do you mind making a PR with this change?

JWT007 added a commit to JWT007/logging-log4j2 that referenced this issue Jan 7, 2025
…der (apache#3369)

Deprecated LoggerConfig.RootLogger.Builder#withtFilter(Filter).

Added LoggerConfig.RoottLogger.Builder#withFilter(Filtter)
JWT007 added a commit to JWT007/logging-log4j2 that referenced this issue Jan 8, 2025
@JWT007
Copy link
Contributor Author

JWT007 commented Jan 8, 2025

@ppkarwasz - made quick change - PR workflow awaiting approval:

#3372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants