Skip to content

Commit ee539f1

Browse files
committed
remove useless code
1 parent 64e7924 commit ee539f1

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

src/server/worker.cc

+1-8
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,10 @@ Worker::Worker(Server *srv, Config *config) : srv(srv), base_(event_base_new())
7777
}
7878

7979
Worker::~Worker() {
80-
// std::vector<redis::Connection *> conns;
81-
// conns.reserve(conns_.size() + monitor_conns_.size());
8280
{
8381
std::lock_guard<std::mutex> guard(conns_mu_);
8482
for (const auto &iter : conns_) {
8583
if (ConnMap::accessor accessor; conns_.find(accessor, iter.first)) {
86-
// conns.emplace_back(accessor->second);
8784
accessor->second->Close();
8885
}
8986
}
@@ -93,14 +90,10 @@ Worker::~Worker() {
9390
std::lock_guard<std::mutex> guard(conns_mu_);
9491
for (const auto &iter : monitor_conns_) {
9592
if (ConnMap::accessor accessor; monitor_conns_.find(accessor, iter.first)) {
96-
// conns.emplace_back(accessor->second);
9793
accessor->second->Close();
9894
}
9995
}
10096
}
101-
// for (const auto &iter : conns) {
102-
// iter->Close();
103-
// }
10497

10598
timer_.reset();
10699
if (rate_limit_group_) {
@@ -477,9 +470,9 @@ void Worker::BecomeMonitorConn(redis::Connection *conn) {
477470
}
478471

479472
void Worker::QuitMonitorConn(redis::Connection *conn) {
473+
std::lock_guard<std::mutex> guard(conns_mu_);
480474
if (ConnMap::accessor accessor; monitor_conns_.find(accessor, conn->GetFD())) {
481475
{
482-
std::lock_guard<std::mutex> guard(conns_mu_);
483476
monitor_conns_.erase(accessor);
484477
accessor.release();
485478
}

0 commit comments

Comments
 (0)