add hash-field-expiration option

Author: jjz921024

kvrocks.conf

@@ -329,6 +329,11 @@ json-max-nesting-depth 1024
 # Default: json
 json-storage-format json
 
+# Whether to enable hash field expiration feature.
+# NOTE: This option only affects newly hash object
+# Default: no
+hash-field-expiration no
+
 ################################## TLS ###################################
 
 # By default, TLS/SSL is disabled, i.e. `tls-port` is set to 0.

src/commands/cmd_hash.cc

@@ -467,6 +467,10 @@ class CommandFieldExpireBase : public Commander {
   }
 
   Status expireFieldExecute(Server *srv, Connection *conn, std::string *output) {
+    if (!srv->storage->GetConfig()->hash_field_expiration) {
+      return {Status::RedisExecErr, "field expiration feature is disabled"};
+    }
+
     std::vector<int8_t> ret;
     redis::Hash hash_db(srv->storage, conn->GetNamespace());
     auto s = hash_db.ExpireFields(args_[1], expire_, fields_, field_expire_type_, &ret);

src/config/config.cc

@@ -190,6 +190,7 @@ Config::Config() {
       {"json-max-nesting-depth", false, new IntField(&json_max_nesting_depth, 1024, 0, INT_MAX)},
       {"json-storage-format", false,
        new EnumField<JsonStorageFormat>(&json_storage_format, json_storage_formats, JsonStorageFormat::JSON)},
+      {"hash-field-expiration", false, new YesNoField(&hash_field_expiration, false)},
 
       /* rocksdb options */
       {"rocksdb.compression", false,

src/config/config.h

@@ -167,6 +167,9 @@ struct Config {
   int json_max_nesting_depth = 1024;
   JsonStorageFormat json_storage_format = JsonStorageFormat::JSON;
 
+  // hash
+  bool hash_field_expiration = false;
+
   struct RocksDB {
     int block_size;
     bool cache_index_and_filter_blocks;

src/types/redis_hash.cc

@@ -301,9 +301,9 @@ rocksdb::Status Hash::MSet(const Slice &user_key, const std::vector<FieldValue>
   rocksdb::Status s = GetMetadata(GetOptions{}, ns_key, &metadata);
   if (!s.ok() && !s.IsNotFound()) return s;
 
-  // For avoid affect existing data,
-  // we only encode ttl of field on new hash object.
-  if (s.IsNotFound()) {
+  // For avoid affect existing data, we only encode ttl of field
+  // on new hash object when hash_field_expiration option is yes.
+  if (s.IsNotFound() && storage_->GetConfig()->hash_field_expiration) {
     metadata.field_encoding = HashSubkeyEncoding::VALUE_WITH_TTL;
   }
 
@@ -517,7 +517,8 @@ rocksdb::Status Hash::ExpireFields(const Slice &user_key, uint64_t expire_ms, co
 
   // we don't support encode ttl on existing hash object
   if (!metadata.IsFieldExpirationEnabled()) {
-    return rocksdb::Status::NotSupported("can't expire fields on hash object whose field expiration feature is disabled");
+    return rocksdb::Status::NotSupported(
+        "can't expire fields on hash object whose field expiration feature is disabled");
   }
 
   rocksdb::ReadOptions read_options = storage_->DefaultMultiGetOptions();