Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Sort] Enhanced sink metric instrumentation for InLong Sort Flink Connector #11201

Closed
2 tasks done
PeterZh6 opened this issue Sep 26, 2024 · 0 comments · Fixed by #11206
Closed
2 tasks done
Milestone

Comments

@PeterZh6
Copy link
Contributor

Description

Parent Issue: #10961

Description:
This feature focuses on SinkMetric only
This feature introduces enhanced metric instrumentation to improve observability within the InLong Sort Flink Connector, specifically for the starrocks connector. The newly added metrics in inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/metric/SinkExactlyMetric.java cover serialization processes, snapshoting states, and checkpoint completion.

Key Metric Categories:

  1. Serialization Metrics:

    • Success/Error Counters: Track successful and failed serialization attempts (numSerializeSuccess, numSerializeError).
    • Latency Gauges: Measure the time taken for both serialization (serializeTimeLag).
  2. SnapshotState Metrics:

    • Creation/Error Counters: Monitor the number of snapshots created and errors encountered during snapshot operations (numSnapshotCreate, numSnapshotError).
  3. NotifyCheckpointComplete Metrics:

    • Completed Snapshots Counter: Track the number of completed checkpoints (numSnapshotComplete).
    • Snapshot-to-Checkpoint Latency: Record the time between snapshot creation and checkpoint completion (snapshotToCheckpointTimeLag).

Implementation Details:

The metrics are integrated into the starrocks connector (located in inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/starrocks) and can be adapted for use in other connectors. Specific changes are made in key methods like serialize(), snapshotState(), and notifyCheckpointComplete() to gather detailed performance and error data.

This feature enhances monitoring capabilities, providing critical insights into serialization performance, checkpoint processes, and other key aspects of the connector's operation.

Use case

No response

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants