Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Version tag for Docker image #8487

Open
zhouyuan opened this issue Jan 9, 2025 · 4 comments
Open

[VL] Version tag for Docker image #8487

zhouyuan opened this issue Jan 9, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@zhouyuan
Copy link
Contributor

zhouyuan commented Jan 9, 2025

Description

Currently Velox backend provides two docker images:

As Gluten will have some breaking compatibility changes like Gcc/JDK, it maybe better to provide a version tag on each release

@zhouyuan zhouyuan added the enhancement New feature or request label Jan 9, 2025
@FelixYBW
Copy link
Contributor

FelixYBW commented Jan 9, 2025

Can we publish a daily updated image with .ccache as well? So user can pull the two images and build Gluten quickly in their env.

@zhouyuan
Copy link
Contributor Author

Can we publish a daily updated image with .ccache as well? So user can pull the two images and build Gluten quickly in their env.

I just did a quick check, in fact the centos7/8 docker image already have .ccache installed. However since the image is only doing build_arrow but does not build_velox so the ccache does not help to speed up velox compile. I think a doable way maybe reusing the dev docker image from Velox https://github.com/facebookincubator/velox/blob/main/.github/workflows/docker.yml#L57

Cc: @PHILO-HE

@PHILO-HE
Copy link
Contributor

We can build velox when building these image and then ccache will be really re-used. But I remember the image size once hit the github action limit.

@FelixYBW
Copy link
Contributor

Let's keep current way then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants