Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][GitHub] merged_date,closed_date not updated when Pull Request is reopened #8241

Open
2 of 3 tasks
konck2 opened this issue Dec 16, 2024 · 2 comments
Open
2 of 3 tasks
Labels
severity/p1 This bug affects functionality or significantly affect ux type/bug This issue is a bug

Comments

@konck2
Copy link

konck2 commented Dec 16, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Syncing data in Devlake doesn't update merged_date and closed_date from pull_requests table when pull request has been closed -> reopened -> merged.

What do you expect to happen

merged_date and closed_date to be updated when Devlake sync job runs.

How to reproduce

  1. Create PR within GitHub
  2. Close it without merging
  3. Run Devlake sync job
  4. Reopen PR
  5. Merge it
  6. Run Devlake sync job

Anything else

pull_request table entry within lake database (MySQL):

updated_at created_date merged_date closed_date
2024-12-16 00:20:36.776 2024-11-26 13:32:32.000 NULL 2024-11-27 08:04:46.000

GitHub API entry:
"created_at": "2024-11-26T13:32:32Z",
"updated_at": "2024-12-03T08:50:29Z",
"closed_at": "2024-12-03T08:50:27Z",
"merged_at": "2024-12-03T08:50:27Z",

Version

1.0.2-beta4

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@konck2 konck2 added the type/bug This issue is a bug label Dec 16, 2024
Copy link

dosubot bot commented Dec 16, 2024

Hey @konck2! 👋 I'm here to help you with any bugs, questions, or contributions you have for Devlake. I'm like a bot with a knack for solving tech puzzles.

A similar issue was previously reported and closed: [Bug][Github] Pull Requests not being updated](#7851). This issue was resolved by a pull request that fixed the GitHub GraphQL collectors to refetch data in incremental mode. You might want to check if this fix is applicable to your situation or if there are any updates related to this in the latest version of DevLake [1].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@dosubot dosubot bot added the severity/p1 This bug affects functionality or significantly affect ux label Dec 16, 2024
@klesh
Copy link
Contributor

klesh commented Dec 17, 2024

Known issue, won't be fixed.
This is a side-effect of #7878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/p1 This bug affects functionality or significantly affect ux type/bug This issue is a bug
Projects
None yet
Development

No branches or pull requests

2 participants