Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADLSFileIO cache DefaultAzureCredentials? #11523

Open
lkindere opened this issue Nov 12, 2024 · 0 comments
Open

ADLSFileIO cache DefaultAzureCredentials? #11523

lkindere opened this issue Nov 12, 2024 · 0 comments
Labels
question Further information is requested

Comments

@lkindere
Copy link

Query engine

Iceberg REST catalog

Question

Currently it looks like when using ADLSFileIO for every request it creates a new client, which then calls

azureProperties.applyClientConfiguration(location.storageAccount(), clientBuilder);

which then ends up creating a new AzureDefaultCredential:

builder.credential(new DefaultAzureCredentialBuilder().build());

Problem with this is that for every single time we have a request, a new token has to be fetched using the AZURE_TENANT_ID, AZURE_CLIENT_ID, AZURE_CLIENT_SECRET
Which I assume would have a performance impact and create a lot of unnecessary requests for the tokens.

Why is there no option to reuse the created DefaultAzureCredentials to utilize default caching?
Am I missing something or is this simply not implemented?

@lkindere lkindere added the question Further information is requested label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant