[Bug]: Rest Connection does not work without credentials

[fhossfel]

Apache Hop version?

2.11

Java version?

17.0.13

Operating system

macOS

What happened?

I was trying to use the Rest Connection without any authorization. It fails with an error 400. The source of the error seems to be that an empty authorization header is sent even when all the authorization fields are not set. It seems that api.openligadb.de does not like this and fails with an error 400.

The error is in org.apache.hop.metadata.rest.RestClient, l. 89:

if (!StringUtils.isEmpty(authorizationPrefix)) {
  invocationBuilder.header(
      authorizationHeaderName, authorizationPrefix + " " + authorizationHeaderValue);
} else {
  invocationBuilder.header(authorizationHeaderName, authorizationHeaderValue);
}

I think this should be surrounded by another if:

if (!StringUtils.isEmpty(authorizationHeaderValue)) {

  if (!StringUtils.isEmpty(authorizationPrefix)) {
    invocationBuilder.header(
        authorizationHeaderName, authorizationPrefix + " " + authorizationHeaderValue);
  } else {
    invocationBuilder.header(authorizationHeaderName, authorizationHeaderValue);
  }

}

*WORK AROND:*Enter bogus values into the the to all there Authorization hear name fields.

TEST: You can use https://api.openligadb.de/getavailableleagues as Test URL (and `https://api.openligadb.de/' AS Base URL).

I can provide a PR if this is of any help but I am not sure if that is any faster.. :-)

Issue Priority

Priority: 3

Issue Component

Component: Metadata

[bamaer]

.take-issue