Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Remove Tencent Cloud SMS dependency #3039

Open
yunfan24 opened this issue Feb 1, 2025 · 1 comment
Open

[Question] Remove Tencent Cloud SMS dependency #3039

yunfan24 opened this issue Feb 1, 2025 · 1 comment

Comments

@yunfan24
Copy link
Contributor

yunfan24 commented Feb 1, 2025

I noticed this TODO in the code. Is this task still needed? If possible, please assign it to me.

@Override
public void send(NoticeReceiver receiver, NoticeTemplate noticeTemplate, GroupAlert alert) {
// SMS notification todo use the rest api not sdk
try {
String instance = null;
String priority = null;
String content = null;
if (alert.getCommonLabels() != null) {

@tomsun28
Copy link
Contributor

tomsun28 commented Feb 2, 2025

hi yes, We plan to use http api calling to replace sdk to call the SMS sending platform, eg tencent sms. welcome have a try if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants