Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Rename tag to a name already exists in the current metalake, it should return 409 instead of 500 #6254

Open
danhuawang opened this issue Jan 15, 2025 · 1 comment · May be fixed by #6298
Open

[Improvement] Rename tag to a name already exists in the current metalake, it should return 409 instead of 500 #6254

danhuawang opened this issue Jan 15, 2025 · 1 comment · May be fixed by #6298
Assignees
@cool9850311
Labels
improvement Improvements on everything

Comments

@danhuawang
Copy link
Contributor

What would you like to be improved?

Image Image
  1. Both tag "high" and tag "@star" are in metalake ml_tag
  2. then rename tag "high" to "@star"
  3. the update tag api return 500 and reason "Tag with name high under metalake ml_tag already exists"

How should we improve?

The update tag api should return 409 conflicts and reason "Tag with name @star under metalake ml_tag already exists"
@danhuawang danhuawang added the improvement Improvements on everything label Jan 15, 2025
@cool9850311
Copy link
Contributor

May I take this?

cool9850311 added a commit to cool9850311/gravitino that referenced this issue Jan 16, 2025
@cool9850311
[apache#6254]Improve: Rename tag to a name already exists in the curr…
89cbe73 
…ent metalake, it should return 409 instead of 500

### What changes were proposed in this pull request?
1. Rename tag to a name already exists in the current metalake, it should return 409 instead of 500
2. The error message should show the correct conflict name
### Why are the changes needed?
### Fix: apache#6254

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
ut
@cool9850311 cool9850311 linked a pull request Jan 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cool9850311 cool9850311

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
2 participants
@cool9850311 @danhuawang