Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] In IcebergRequestContext.java httpServletRequest is deprecated but still used #6274

Open
justinmclean opened this issue Jan 16, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@justinmclean
Copy link
Member

Version

main branch

Describe what's wrong

In IcebergRequestContext.java httpServletRequest is deprecated but still used in the constructor.

  this.httpServletRequest = httpRequest;

A comment states "To keep compatibility with old IcebergRequestContext, will remove in new release."

Error message and/or stacktrace

Should this be fixed in this release?

How to reproduce

Current main (0.7)

Additional context

No response

@justinmclean justinmclean added 0.8.0 Release v0.8.0 bug Something isn't working labels Jan 16, 2025
@FANNG1
Copy link
Contributor

FANNG1 commented Jan 16, 2025

This is deprecated in 0.8, so may remove it in 0.10 or latter version .

@justinmclean
Copy link
Member Author

If it deprecated in 0.8, why are we still using it?

@FANNG1
Copy link
Contributor

FANNG1 commented Jan 16, 2025

This is the event API published to user, we should keep compatibility to make old code works.

@jerryshao jerryshao removed the 0.8.0 Release v0.8.0 label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants