Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Possible resource leak in BaseCatalog.java #6236

Open
justinmclean opened this issue Jan 15, 2025 · 1 comment · May be fixed by #6253
Open

[Improvement] Possible resource leak in BaseCatalog.java #6236

justinmclean opened this issue Jan 15, 2025 · 1 comment · May be fixed by #6253
Assignees
@Abyss-lord
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

At line 209 there looks to be an issue with not cleaning up authorization.

How should we improve?

Use try-with-resources or close this "BaseAuthorization" in a "finally" clause.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Jan 15, 2025
@Abyss-lord
Copy link
Contributor

I would like to work on it.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 15, 2025
@Abyss-lord
[apache#6236] fix(core): fix possible resource leak in BaseCatalog
62d140a 
fix  possible resource leak in BaseCatalog.
@Abyss-lord Abyss-lord linked a pull request Jan 15, 2025 that will close this issue
Open
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 15, 2025
@Abyss-lord
[apache#6236] fix(core): fix possible resource leak in BaseCatalog
b669a0b 
fix  possible resource leak in BaseCatalog.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 15, 2025
@Abyss-lord
[apache#6236] fix(core): fix possible resource leak in BaseCatalog
71c717a 
fix  possible resource leak in BaseCatalog.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 15, 2025
@Abyss-lord
[apache#6236] fix(core): fix possible resource leak in BaseCatalog
a655913 
fix conflict.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 15, 2025
@Abyss-lord
[apache#6236] fix(core): fix possible resource leak in BaseCatalog
1d1b13c 
fix conflict.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 15, 2025
@Abyss-lord
[apache#6236] fix(core): fix possible resource leak in BaseCatalog
5ab931d 
fix conflict.
@justinmclean justinmclean changed the title [Improvement] Possible resourse leak in BaseCatalog.java [Improvement] Possible resource leak in BaseCatalog.java Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6236] fix(core): fix possible resource leak in BaseCatalog Abyss-lord/gravitino
2 participants
@justinmclean @Abyss-lord