Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add tag support to Models in Gravtitino CLI #6242

Closed
justinmclean opened this issue Jan 15, 2025 · 1 comment · Fixed by #6284
Closed

[Improvement] Add tag support to Models in Gravtitino CLI #6242

justinmclean opened this issue Jan 15, 2025 · 1 comment · Fixed by #6284
Assignees
@Abyss-lord
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

TYag support is being added to models (see #6222/#6228) the CLI should also support this.

How should we improve?

See above
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Jan 15, 2025
@Abyss-lord
Copy link
Contributor

I would like to work on it.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 16, 2025
@Abyss-lord
[apache#6242] improve(CLI): Add tag support to Models in Gravtitino CLI.
5394f16 
Add tag support to Models in Gravtitino CLI. currently, the CLI support untagEntity, tagEntity, listTags from a model.
@Abyss-lord Abyss-lord mentioned this issue Jan 16, 2025
Merged
justinmclean pushed a commit that referenced this issue Jan 16, 2025
@Abyss-lord
[#6242] improve(CLI): Add tag support to Models in Gravtitino CLI. (#…
24952c9 
…6284)

### What changes were proposed in this pull request?

Add tag support to Models in Gravtitino CLI. currently, the CLI support
following actions:
1. `UntagEntity`, 
2. `TagEntity`,  
3. `ListEntityTags`

### Why are the changes needed?

Fix: #6242 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6242] improve(CLI): Add tag support to Models in Gravtitino CLI. Abyss-lord/gravitino
2 participants
@justinmclean @Abyss-lord