Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] dubbo3.3.0, revision parameter of interface metadata, come from pom.xml's ${project.parent.version} instead of ${project.version} #14728

Open
3 of 4 tasks
aliuql opened this issue Sep 27, 2024 · 2 comments
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@aliuql
Copy link

aliuql commented Sep 27, 2024

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

dubbo java 3.3.0, jdk 17, linux

Steps to reproduce this issue

i package a spring boot jar, named: dubbo-samples-spring-boot-provider-2.0.jar
and pom.xml of this jar (location: META-INF\maven\org.apache.dubbo\dubbo-samples-spring-boot-provider\pom.xml)
as follows:

<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>

  <parent>
    <groupId>org.apache.dubbo</groupId>
    <artifactId>dubbo-samples-spring-boot</artifactId>
    <version>1.1</version>
    <relativePath>../pom.xml</relativePath>
  </parent>

  <artifactId>dubbo-samples-spring-boot-provider</artifactId>
  <version>2.0</version>

<project/>

i opend the flag: dubbo.metadata-report.report-metadata: true
and when i start this jar, command like this:
java -jar dubbo-samples-spring-boot-provider-2.0.jar

it will report metadata to nacos, and nacos metadata like this:
image

the param revision of serviceKey: test1/org.apache.dubbo.springboot.demo.DemoService:1.0:dubbo, is 1.1, why not 2.0 ?

What you expected to happen

the revision param of interface, will it be better get from ${project.verion} of pom.xml ?

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@aliuql aliuql added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Sep 27, 2024
@AlbumenJ
Copy link
Member

This revision is fetched by jar name. You can check org.apache.dubbo.common.Version

@aliuql
Copy link
Author

aliuql commented Oct 8, 2024

but i start with the cmd:
java -jar dubbo-samples-spring-boot-provider-2.0.jar
it register revision: 1.1

may be it caused by spring boot 's jar package mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants