Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] TotalPendingBytes size overflow Exception #14635

Open
4 tasks done
caoyanan666 opened this issue Sep 5, 2024 · 1 comment
Open
4 tasks done

[Feature] TotalPendingBytes size overflow Exception #14635

caoyanan666 opened this issue Sep 5, 2024 · 1 comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@caoyanan666
Copy link
Contributor

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

I was called to handle a exception, which is
Caused by: io.netty.handler.codec.http2.Http2Exception$StreamException: TotalPendingBytes size overflow for stream: 9
at io.netty.handler.codec.http2.Http2Exception.streamError(Http2Exception.java:151)

I used the triple protocol, and then the flow control intercepted it.

I found that the initialWindowSize of TriHttp2RemoteFlowController is read from the dubbo.rpc.tri.initial-window-size parameter, but the default value is 64KB. However, TripleHttp2Protocol also reads from the environment variable to build Http2Settings, but the nettyServer initWindowSize initialized by TripleHttp2Protocol is 8MB. I now get an error of 64KB in the production environment. I am going to configure it to 1MB, but TripleHttp2Protocol drops from 8MB to 1MB. My question is, why is the value read from an environment variable, the default value of TripleHttp2Protocol is 8MB, but the flow control is only 64KB

Related issues

#13676

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@caoyanan666 caoyanan666 added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Sep 5, 2024
@caoyanan666 caoyanan666 changed the title [Feature] TriHttp2 [Feature] TotalPendingBytes size overflow Exception Sep 5, 2024
@JunJieLiu51520
Copy link
Contributor

JunJieLiu51520 commented Sep 9, 2024

emm, i think it should be spilit from 'dubbo.rpc.tri.initial-window-size' in TriHttp2RemoteFlowController, details refer to the pr #14657

@AlbumenJ PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants