-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diff function in the edit spec screen #17018
Labels
Comments
It looks like this feature snuck in with this PR: #16696 Seems like it's set to release with V31 - I'm running a V31 snapshot and have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It would be very useful if a diff function could be added to the ingestion spec editor alongside the "Submit Spec" button. I often do changes manually by editing the spec JSON and having the ability to do a diff before I submit would allow for checking that the changes being made are what was intended. Sometimes, if there are several changes being done (e.g. updating/adding dimensions or transformations), a lapse in focus can result in not being sure about what has/has not been changed. I have abandoned changes many times and had to restart because I was not positive about what changed before I submitted the updated spec
Motivation
The ability to jump to an ingestion spec from the supervisor is one of the handier functions I use. As well, the ability to do diffs between a version and the previous version has been useful for seeing if a mistake has been introduced. Having that diff function be available before committing the change would help prevent some mistakes from being introduced, rather than going back to look for the error after things have gone wrong.
Thanks,
Sean
The text was updated successfully, but these errors were encountered: