Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Display for ColumnarValue #14176

Closed
jayzhan211 opened this issue Jan 18, 2025 · 5 comments · Fixed by #14220
Closed

Implement Display for ColumnarValue #14176

jayzhan211 opened this issue Jan 18, 2025 · 5 comments · Fixed by #14220
Assignees
@zjregee @Kunal-Singh-Dadhwal
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jayzhan211
Copy link
Contributor

Is your feature request related to a problem or challenge?

For ArrayRef, you can use

pretty_format_columns("ColumnarValue(ArrayRef)", &[array_ref]).unwrap())

Describe the solution you'd like

Implement Display as a readable information

Describe alternatives you've considered

No response

Additional context

No response
@jayzhan211 jayzhan211 added enhancement New feature or request good first issue Good for newcomers labels Jan 18, 2025
@Kunal-Singh-Dadhwal
Copy link

take

@Kunal-Singh-Dadhwal
Copy link

@jayzhan211 I’m still getting familiar with the codebase and Rust, I don’t feel ready to tackle it just yet.

@Kunal-Singh-Dadhwal
Copy link

@jayzhan211 I’m still getting familiar with the codebase and Rust, I don’t feel ready to tackle it just yet.

@alamb

@zjregee
Copy link
Member

zjregee commented Jan 20, 2025

Hi, @Kunal-Singh-Dadhwal, can I take this?

@Kunal-Singh-Dadhwal
Copy link

@zjregee Yes

@zjregee zjregee mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zjregee zjregee

@Kunal-Singh-Dadhwal Kunal-Singh-Dadhwal

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement display for ColumnarValue zjregee/datafusion
3 participants
@jayzhan211 @zjregee @Kunal-Singh-Dadhwal