Move SanityChecker into datafusion-physical-optimizer crate

[alamb]

Is your feature request related to a problem or challenge?

• Part of [EPIC] Extract remaining physical optimizer out of core #11502
• Related to Building project takes a *long* time (esp compilation time for datafusion core crate) #13814

Historically DataFusion was one (very) large crate datafusion, and as it grew bigger we extracted various functionality into separate crates. This leads to both faster compile times (as the crates can be compiled in parallel) as well easier to navigate code (as the crates force a cleaner dependency separation)

One project we have not yet completed is to extract the physical optimizer passes out #11502

• The original physical optimizers are here https://github.com/apache/datafusion/tree/main/datafusion/core/src/physical_optimizer
• The new crate is here https://github.com/apache/datafusion/tree/main/datafusion/physical-optimizer

Describe the solution you'd like

Extract the SanityChecker from the datafusion core crate to the datafusion-physical-optimizer crate

Describe alternatives you've considered

Move https://github.com/apache/datafusion/blob/main/datafusion/core/src/physical_optimizer/sanity_checker.rs to
https://github.com/apache/datafusion/tree/main/datafusion/physical-optimizer/src/sanity_checker.rs

Additional context

Here is an example PR:

• Move Pruning into physical-optimizer crate #13485

I think this is a good first issue as it is mostly mechanical and does not require deep internals knowledge

[cj-zhukov]

take

[alamb]

Thanks @cj-zhukov !

[mnpw]

@cj-zhukov Apologies, I started working on this PR without explicitly assigning it to myself. Would appreciate your review on #14083.

[cj-zhukov]

@mnpw OK, to avoid such situation in the future, please be attentive in following the rules

[alamb]

@mnpw OK, to avoid such situation in the future, please be attentive in following the rules

FWIW the guidelines are here:
https://datafusion.apache.org/contributor-guide/index.html#open-contribution-and-assigning-tickets

TLDR it is polite (but not required) to give a heads up on the ticket

[cj-zhukov]

@mnpw OK, to avoid such situation in the future, please be attentive in following the rules

FWIW the guidelines are here: https://datafusion.apache.org/contributor-guide/index.html#open-contribution-and-assigning-tickets

TLDR it is polite (but not required) to give a heads up on the ticket

Andrew, thanks for the clarification and sharing the guidelines! I’ll keep this in mind going forward.