Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[substrait] more abstract SubstraitConsumer API #13863

Open
vbarua opened this issue Dec 20, 2024 · 0 comments
Open

[substrait] more abstract SubstraitConsumer API #13863

vbarua opened this issue Dec 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@vbarua
Copy link
Contributor

vbarua commented Dec 20, 2024

Is your feature request related to a problem or challenge?

The code in #13803 adds a SubstraitConsumer trait that explicitly includes the following methods

    fn get_extensions(&self) -> &Extensions;
    fn get_function_registry(&self) -> &impl FunctionRegistry;

these methods are used by implementors to retrieve structs, which they can then use to resolve and map functions from Substrait into DataFusion.

IMO, these structs are internal implementations detail and should be replace by dedicated methods that do not leak these details.

Describe the solution you'd like

Identify / devise a series of API methods for the SubstraitConsumer that can be used to replace the calls to get_extensions and get_function_registry.

This may require rethinking how functions are mapped from Substrait to DataFusion

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant