We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The code in #13803 adds a SubstraitConsumer trait that explicitly includes the following methods
SubstraitConsumer
fn get_extensions(&self) -> &Extensions; fn get_function_registry(&self) -> &impl FunctionRegistry;
these methods are used by implementors to retrieve structs, which they can then use to resolve and map functions from Substrait into DataFusion.
IMO, these structs are internal implementations detail and should be replace by dedicated methods that do not leak these details.
Identify / devise a series of API methods for the SubstraitConsumer that can be used to replace the calls to get_extensions and get_function_registry.
get_extensions
get_function_registry
This may require rethinking how functions are mapped from Substrait to DataFusion
No response
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Is your feature request related to a problem or challenge?
The code in #13803 adds a
SubstraitConsumer
trait that explicitly includes the following methodsthese methods are used by implementors to retrieve structs, which they can then use to resolve and map functions from Substrait into DataFusion.
IMO, these structs are internal implementations detail and should be replace by dedicated methods that do not leak these details.
Describe the solution you'd like
Identify / devise a series of API methods for the SubstraitConsumer that can be used to replace the calls to
get_extensions
andget_function_registry
.This may require rethinking how functions are mapped from Substrait to DataFusion
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: