Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test DataFusion 44.0.0 with Sail #13855

Open
Tracked by #13334
shehabgamin opened this issue Dec 20, 2024 · 6 comments
Open
Tracked by #13334

Test DataFusion 44.0.0 with Sail #13855

shehabgamin opened this issue Dec 20, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@shehabgamin
Copy link
Contributor

Is your feature request related to a problem or challenge?

We are trying to make sure the upgrade experience for DataFusion is better and to do so we are hoping to improve the testing of major downstream projects

For version 44.0.0 we would like to test with Sail prior to release.

Describe the solution you'd like

I would like to create a PR to test DataFusion Sail with a pre-released version of DataFusion (pinned to the main branch)

Describe alternatives you've considered

No response

Additional context

lakehq/sail#335

@shehabgamin shehabgamin added the enhancement New feature or request label Dec 20, 2024
@shehabgamin
Copy link
Contributor Author

Take

@shehabgamin
Copy link
Contributor Author

Smooth Sailing testing commit 5d563d9 from DataFusion main branch.

The following test reports run tests on the PR branch and compares them against the tests from the Sail main branch:

Will re-test once there is a release candidate.

@Omega359
Copy link
Contributor

Smooth Sailing testing commit 5d563d9 from DataFusion main branch.

The following test reports run tests on the PR branch and compares them against the tests from the Sail main branch:

* [DataFusion 44.0.0 Pre-Release Testing lakehq/sail#335 (comment)](https://github.com/lakehq/sail/pull/335#issuecomment-2556353768)

* [DataFusion 44.0.0 Pre-Release Testing lakehq/sail#335 (comment)](https://github.com/lakehq/sail/pull/335#issuecomment-2556416669)

After a brief review of the errors I suspect there may be something up with lists and structs but I would have to see the actual logic being tested to know for certain. Many of the errors are expected - functions not existing, etc.

@alamb
Copy link
Contributor

alamb commented Dec 20, 2024

After a brief review of the errors I suspect there may be something up with lists and structs but I would have to see the actual logic being tested to know for certain. Many of the errors are expected - functions not existing, etc.

I feel like we have had several bugs / issues with structs / lists the last few releases so it would be amazing if we could figure out what is going on before the release. @shehabgamin is this something you can help with?

@shehabgamin
Copy link
Contributor Author

shehabgamin commented Dec 20, 2024

After a brief review of the errors I suspect there may be something up with lists and structs but I would have to see the actual logic being tested to know for certain. Many of the errors are expected - functions not existing, etc.

I feel like we have had several bugs / issues with structs / lists the last few releases so it would be amazing if we could figure out what is going on before the release. @shehabgamin is this something you can help with?

@Omega359 @alamb For sure, I will gladly take a look! If there are issues with lists and/or structs, it likely wouldn't be due to changes in the 44.0.0 pre-release that I tested, though. The Sail main branch and the PR branch that is testing the pre-release have the exact same errors (with the exception of slight rewording of some error logs).

This leads me to believe that any issues with lists and/or structs would likely be preexisting. I will take a close look at all of the errors, but, with that in mind, should we scope the issues into a separate GitHub issue if we do find errors? Also @Omega359, let me know if any errors in particular caught your eye.

@alamb
Copy link
Contributor

alamb commented Dec 21, 2024

This leads me to believe that any issues with lists and/or structs would likely be preexisting. I will take a close look at all of the errors, but, with that in mind, should we scope the issues into a separate GitHub issue if we do find errors? Also @Omega359, let me know if any errors in particular caught your eye.

That would make sense. Glad to hear the errors aren't new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants