Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci improvements #13876

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

ci improvements #13876

wants to merge 12 commits into from

Conversation

Omega359
Copy link
Contributor

@Omega359 Omega359 commented Dec 21, 2024

Which issue does this PR close?

Closes #13846, part of #13845

Rationale for this change

Improve ci run time

What changes are included in this PR?

  • disable intel mac job
  • switch to nextest where possible
  • improved cached
  • checkout with depth=1
  • ci cargo profile that disables debug, etc in dependencies

Are these changes tested?

yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Dec 21, 2024
@Omega359 Omega359 marked this pull request as ready for review December 21, 2024 20:01
@comphead
Copy link
Contributor

comphead commented Dec 21, 2024

Thanks @Omega359 is it a draft? I dont see tests in checks

@Omega359
Copy link
Contributor Author

Thanks @Omega359 is it a draft? I dont see tests in checks

No, but it should be. I can't seem to make it draft but apparently taiki-e/install-action@nextest is not an allowed action in apache repo's.

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Dec 22, 2024
@Omega359
Copy link
Contributor Author

I've reverted the nextest changes for now as the github action to install the binary of it is not approved and building nextest from source would take longer than the time it saves when running tests.

Also noted that some of the non-apache/github actions used in datafusion's ci use versions vs githash of a validated version which is against the apache github action policy.

For example: mozilla-actions/[email protected]

We likely should file another ticket to see change all third-party actions to be githash vs version

@Omega359
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contemplate stop CI testing on intel mac
2 participants